PR #1: Add TDD tests for correct edge_map semantics #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test_edge_map.py with tests that demonstrate the desired behavior: - edge_map should operate on edge labels (edge_id), not indices - edge_map should validate that target values exist in the graph - edge_map should allow merging multiple edges to a single label These tests currently fail due to the current implementation mixing segment indices with edge labels. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Closed
Closed
Contributor
Author
|
Superseded by PR #7 which includes these tests plus the implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
edge_mapsemanticsedge_mapshould work on edge labels (edge_id), not segment indicesValueErrorTest plan
🤖 Generated with Claude Code