Skip to content

Commit e0bb9e6

Browse files
committed
update test from review comments
1 parent 50f9b8c commit e0bb9e6

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

src/trodes_to_nwb/tests/test_spikegadgets_io.py

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -447,12 +447,12 @@ def test_produce_ephys_channel_ids():
447447
assert len(result_5) == n_recorded_5
448448

449449
# --- Edge Cases ---
450-
result_5 = SpikeGadgetsRawIO._produce_ephys_channel_ids(0, 0, 32)
451-
assert result_5 == []
452-
result_6 = SpikeGadgetsRawIO._produce_ephys_channel_ids(128, 128, 0)
450+
result_6 = SpikeGadgetsRawIO._produce_ephys_channel_ids(0, 0, 32)
453451
assert result_6 == []
454-
result_7 = SpikeGadgetsRawIO._produce_ephys_channel_ids(0, 0, 0)
452+
result_7 = SpikeGadgetsRawIO._produce_ephys_channel_ids(128, 128, 0)
455453
assert result_7 == []
454+
result_8 = SpikeGadgetsRawIO._produce_ephys_channel_ids(0, 0, 0)
455+
assert result_8 == []
456456

457457
# --- Error Cases ---
458458
with pytest.raises(ValueError) as excinfo:
@@ -461,3 +461,13 @@ def test_produce_ephys_channel_ids():
461461
with pytest.raises(ValueError) as excinfo:
462462
SpikeGadgetsRawIO._produce_ephys_channel_ids(65, 65, 16)
463463
assert "multiple of channels per chip" in str(excinfo.value)
464+
with pytest.raises(ValueError) as excinfo:
465+
SpikeGadgetsRawIO._produce_ephys_channel_ids(
466+
64,
467+
63,
468+
16,
469+
)
470+
assert "hw_channels_recorded must be provided" in str(excinfo.value)
471+
with pytest.raises(ValueError) as excinfo:
472+
SpikeGadgetsRawIO._produce_ephys_channel_ids(64, 63, 16, ["1", "2", "3"])
473+
assert "hw_channels_recorded must be provided" in str(excinfo.value)

0 commit comments

Comments
 (0)