Skip to content

Conversation

@samuelbray32
Copy link
Collaborator

Fixes #126

  • in add electrode groups, assign ref_elect_id = -1 in the electrodes table in cases where the reference was not used
  • add test for this case

@samuelbray32 samuelbray32 requested a review from Copilot July 23, 2025 14:49

This comment was marked as outdated.

@edeno edeno requested review from Copilot and removed request for Copilot July 23, 2025 14:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes handling of cases where no reference electrode is specified for electrode groups. The change modifies the add_electrode_groups function to assign ref_elect_id = -1 when no reference electrode is used, addressing issue #126.

  • Adds logic to handle reference electrode map entries with "-1" indicating no reference
  • Includes test coverage for the no-reference electrode scenario

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/trodes_to_nwb/convert_yaml.py Adds conditional logic to handle "-1" reference electrode case
src/trodes_to_nwb/tests/test_convert_yaml.py Adds test function to verify no-reference electrode behavior

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (883a2a4) to head (777da04).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.01%     
==========================================
  Files          13       13              
  Lines        1686     1689       +3     
==========================================
+ Hits         1509     1512       +3     
  Misses        177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuelbray32 samuelbray32 requested a review from edeno July 23, 2025 15:22
@edeno edeno merged commit 08f776e into main Jul 23, 2025
10 checks passed
@edeno edeno deleted the no_ref_elect branch July 23, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure with null reference nTrode

3 participants