-
Notifications
You must be signed in to change notification settings - Fork 4
Handle no Reference Electrode #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes handling of cases where no reference electrode is specified for electrode groups. The change modifies the add_electrode_groups function to assign ref_elect_id = -1 when no reference electrode is used, addressing issue #126.
- Adds logic to handle reference electrode map entries with "-1" indicating no reference
- Includes test coverage for the no-reference electrode scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/trodes_to_nwb/convert_yaml.py | Adds conditional logic to handle "-1" reference electrode case |
| src/trodes_to_nwb/tests/test_convert_yaml.py | Adds test function to verify no-reference electrode behavior |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 89.50% 89.52% +0.01%
==========================================
Files 13 13
Lines 1686 1689 +3
==========================================
+ Hits 1509 1512 +3
Misses 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #126
ref_elect_id = -1in the electrodes table in cases where the reference was not used