-
Notifications
You must be signed in to change notification settings - Fork 4
Quickfix: Run add_optogenetic_epochs #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
edeno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me with a changelog update
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 89.48% 89.53% +0.05%
==========================================
Files 13 13
Lines 1693 1711 +18
==========================================
+ Hits 1515 1532 +17
- Misses 178 179 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a quickfix to properly call add_optogenetic_epochs within the NWB creation process and addresses a write error caused by differently shaped spatial node arrays between optogenetic epochs.
- Integrate
add_optogenetic_epochsfunction call into the main NWB creation workflow - Fix array shape inconsistencies in optogenetic epoch spatial filter data by padding arrays to uniform dimensions
- Add fs_gui_dir parameter support throughout the conversion pipeline to enable optogenetic file discovery
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/trodes_to_nwb/convert.py | Adds fs_gui_dir parameter and calls add_optogenetic_epochs in _create_nwb |
| src/trodes_to_nwb/convert_optogenetics.py | Implements array padding logic to fix spatial node shape inconsistencies |
| src/trodes_to_nwb/tests/test_convert.py | Updates test calls to include fs_gui_dir parameter |
| src/trodes_to_nwb/tests/test_convert_optogenetics.py | Updates test to expect corrected array shape |
| CHANGELOG.md | Documents the optogenetics-related fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
add_optogenetic_epochswithin_create__nwb