-
Notifications
You must be signed in to change notification settings - Fork 4
Add probe yamls for Livermore probes #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds three missing YAML configuration files for Livermore probe metadata, specifically providing electrode layout specifications for different 128-channel polyimide probes with varying contact sizes and spacing.
- Adds metadata files for three probe variants: 4mm (15um/26um), 6mm (20um/40um), and 8mm (15um/26um) spacing configurations
- All probes share a common 4-shank, 128-electrode layout with different dimensional parameters
- Provides complete electrode positioning data for each shank with relative x, y, z coordinates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| 128c-4s8mm6cm-15um-26um-sl.yml | Adds probe metadata for 8mm variant with 15um contact size and 26um spacing |
| 128c-4s6mm6cm-20um-40um-sl.yml | Adds probe metadata for 6mm variant with 20um contact size and 40um spacing |
| 128c-4s4mm6cm-15um-26um-sl.yml | Adds probe metadata for 4mm variant with 15um contact size and 26um spacing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
edeno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Can you fix the test?
|
@edeno uh what is this test and how do i fix it? |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 13 13
Lines 1711 1711
=======================================
Hits 1532 1532
Misses 179 179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add yaml files for Livermore probes that were missing