Skip to content

Conversation

@khl02007
Copy link
Contributor

@khl02007 khl02007 commented Sep 4, 2025

Add yaml files for Livermore probes that were missing

@edeno edeno requested a review from Copilot September 4, 2025 23:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds three missing YAML configuration files for Livermore probe metadata, specifically providing electrode layout specifications for different 128-channel polyimide probes with varying contact sizes and spacing.

  • Adds metadata files for three probe variants: 4mm (15um/26um), 6mm (20um/40um), and 8mm (15um/26um) spacing configurations
  • All probes share a common 4-shank, 128-electrode layout with different dimensional parameters
  • Provides complete electrode positioning data for each shank with relative x, y, z coordinates

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
128c-4s8mm6cm-15um-26um-sl.yml Adds probe metadata for 8mm variant with 15um contact size and 26um spacing
128c-4s6mm6cm-20um-40um-sl.yml Adds probe metadata for 6mm variant with 20um contact size and 40um spacing
128c-4s4mm6cm-15um-26um-sl.yml Adds probe metadata for 4mm variant with 15um contact size and 26um spacing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@edeno edeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Can you fix the test?

@khl02007
Copy link
Contributor Author

khl02007 commented Sep 4, 2025

@edeno uh what is this test and how do i fix it?

@edeno
Copy link
Collaborator

edeno commented Sep 5, 2025

FAILED src/trodes_to_nwb/tests/test_convert.py::test_get_included_device_metadata_paths - AssertionError: assert 19 == 16

@edeno edeno requested a review from samuelbray32 September 5, 2025 00:06
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.53%. Comparing base (9541a17) to head (1365d8f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files          13       13           
  Lines        1711     1711           
=======================================
  Hits         1532     1532           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuelbray32 samuelbray32 merged commit de6d302 into LorenFrankLab:main Sep 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants