Skip to content

Conversation

@samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Oct 10, 2025

  • Error identified where the timesteps in sample_counts was innapropriately scaled to nanoseconds, even though units required to be seconds
  • Correctly stores as seconds and adjusts test

@samuelbray32 samuelbray32 requested review from Copilot and edeno October 10, 2025 20:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes timestamp scaling bug in sample_counts where timestamps were incorrectly scaled to nanoseconds instead of being stored as seconds as required by the NWB format.

  • Removes nanosecond scaling multiplication from sample_counts timestamp processing
  • Adds test adjustment to account for the timestamp unit correction when comparing with old files

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/trodes_to_nwb/convert_intervals.py Removes incorrect nanosecond scaling from systime timestamps
src/trodes_to_nwb/tests/test_convert_intervals.py Adds nanosecond conversion factor and adjusts test to handle unit correction

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.73%. Comparing base (5359ff6) to head (b67db5c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files          13       13           
  Lines        1704     1704           
=======================================
  Hits         1529     1529           
  Misses        175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edeno edeno merged commit 732a3b3 into main Oct 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants