feat: added renderError fire event when a render issue occurs#526
Merged
feat: added renderError fire event when a render issue occurs#526
Conversation
🦋 Changeset detectedLatest commit: fcd1316 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/web/src/dotlottie.ts:542
- Verify that _dispatchError dispatches the intended 'loadError' event, matching the PR title and description. If it only serves a generic role, consider renaming it or ensuring its configuration clearly reflects the loadError event.
this._dispatchError(`Error in animation frame: ${error}`);
Contributor
Coverage Report for @lottiefiles/dotlottie-web (packages/web)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Coverage Report for @lottiefiles/dotlottie-react (packages/react)
File CoverageNo changed files found. |
Contributor
Coverage Report for @lottiefiles/dotlottie-wc (packages/wc)
File CoverageNo changed files found. |
Contributor
size-limit report 📦
|
theashraf
reviewed
Apr 22, 2025
Member
theashraf
left a comment
theashraf
left a comment
There was a problem hiding this comment.
Looks good to merge, but few things left:
- fix type-check issues
- comments to resolve
samuelOsborne
changed the title
theashraf
force-pushed
the
fix/crash-event-on-draw
branch
from
ec4160a to
e9c131b
Compare
theashraf
changed the title
theashraf
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fires a loadError event when loading succeeds but rendering doesn't inside draw().
Type of change
Checklist