Skip to content

FIX: cannot handle parameters naming with underscore correctly. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nakrakiiya
Copy link

luadocumentor cannot handle parameters naming with underscore correctly. e.g. aaa_bbb_ccc, aaa_bbb

this patch is to fix this problem

Copy link

@FlightControl-User FlightControl-User left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is damaging a previous fix, which is to ensure that @{} comments are correctly handled! Please don't accept this pull request!

@sbernard31
Copy link
Contributor

@FlightControl-User do you confirm the bug above ?

Do you have any idea about a better fix ?

31726a8 seems out of topic but should be better handle encoding ?

@FlightControl-User
Copy link

FlightControl-User commented May 23, 2018

I am working on it and will do a pull request.

@FlightControl-User
Copy link

FlightControl-User commented May 23, 2018

The encoding change may be indeed good. I will embed that change into the package...

@FlightControl-User
Copy link

FlightControl-User commented May 23, 2018

Also a comment on markdown....

A word AI_A2A_DISPATCHER should not appear as AI_A2A_DISPATCHER ... with the A2A in italics... this should be a fix done in markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants