Skip to content

Fix escaped underscore \_ names to be displayed in escaped mode. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

FlightControl-User
Copy link

  • added a purename method that does the same as prettyname, but does not escape the text.
  • added a purelinkto method that does the same as fulllinkto, but does not escape the linked text.
  • documented.

@sbernard31
Copy link
Contributor

Thx for the PR.

I away from this part of the code since a long time, so let's try to re-put this in mind.

The issue is about _ which is escaped in "link" and "prettyname".
We "escape" _ to avoid issue with markdown and @{}.

If I'm right I think we should not escape in fulllink and prettyname.
And just fix format function in template engine.

Does it make sense ?

@FlightControl-User
Copy link
Author

FlightControl-User commented May 29, 2018

I think it does. However, this may require changes in a lot of places.
I have started to dive into this code heavily. I am adapting the code to support the W3.css styling framework. This allows to remove those lists of types and properties and make them clickable.
Also I want later the pages to show the inherited class hierarchy. Which is a challenge as the types are located per _File record.
Modifying the templates etc. to W3.
I learn a lot by doin this. It is amazing what has been done. Especially with meta-lua.
We'll let it rest for the moment until I get a better understanding where those change points are to avoid the escaping.

There's is another burning issue. Problems with the escaping in hyperlinks is one. But what about markdown that contains A2A_CARGO_DISPATCHER...
The CARGO shouldn't be in italics...

@sbernard31
Copy link
Contributor

I think it does. However, this may require changes in a lot of places.

I thought my idea will change less code.

Problems with the escaping in hyperlinks is one. But what about markdown that contains A2A_CARGO_DISPATCHER...
The CARGO shouldn't be in italics...

I think this is a bug in markdown.lua library.
Maybe this fixed in a more recent version of https://luarocks.org/modules/mpeterv/markdown

@FlightControl-User
Copy link
Author

I'll carefully evaluate your recommendation. But right now I wanna get that w3.css implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants