Add support for jmx prometheus exporter#71
Conversation
fjammes
commented
Jul 17, 2025
- Add python/scala code to store sparkMeasure metrics inside JMX
- Write unit test for jmxexport() function
- Add documentation
- Document how to run unit test
- Add integration tests over k8s
- Write unit test for jmxexport function - Add documentation - Document how to run unit test - Add integration tests over k8s
|
Hi @LucaCanali , here is the PR related to issue #67 . Thanks in advance for you review. In addition, I've added a job which run e2e tests inside Github action. |
b76fdb2 to
db40f38
Compare
|
Hi @LucaCanali , I am trying to fix a minor error in e2e test in Github Actions (it runs fine on a regular commit but not on a PR). Could you please approve my 2 workflows? As you can see it works fine on a regular commit push: https://github.com/k8s-school/sparkMeasure/actions/runs/16571225806/job/46863741443 |
|
Hi @LucaCanali Would you mind re-triggering the tests on the PR? I even created a fake PR on my own repo to simulate the scenario and everything went fine there: Thanks! |
|
Hi @LucaCanali, All CI tests have passed. Could you please complete your review and then merge? Thanks! Best, |
There was a problem hiding this comment.
Thank you @fjammes for all the work on this.
A minor comment about Dockerfile, can you please add some header comment there on the general purpose of this Dockerfile and transalte the existing comments into English.
|
Another point concerns the maintainability of this new component, including its code, Dockerfiles, and dependencies. Could we consider a strategy to make future troubleshooting and dependency updates easier, especially as new versions become available? |
|
Hi @LucaCanali, I'm happy to dedicate time to the long-term maintenance of this component. Feel free to ask if you need anything else. Best regards, |
|
I have merged the change however there seems to be a problem with the job Run spark-measure end-to-end tests |