Skip to content

Add support for jmx prometheus exporter#71

Merged
LucaCanali merged 4 commits intoLucaCanali:masterfrom
k8s-school:issue-67
Jul 30, 2025
Merged

Add support for jmx prometheus exporter#71
LucaCanali merged 4 commits intoLucaCanali:masterfrom
k8s-school:issue-67

Conversation

@fjammes
Copy link
Copy Markdown
Contributor

@fjammes fjammes commented Jul 17, 2025

  • Add python/scala code to store sparkMeasure metrics inside JMX
  • Write unit test for jmxexport() function
  • Add documentation
  • Document how to run unit test
  • Add integration tests over k8s

- Write unit test for jmxexport function
- Add documentation
- Document how to run unit test
- Add integration tests over k8s
@fjammes
Copy link
Copy Markdown
Contributor Author

fjammes commented Jul 17, 2025

Hi @LucaCanali , here is the PR related to issue #67 . Thanks in advance for you review. In addition, I've added a job which run e2e tests inside Github action.

@fjammes fjammes force-pushed the issue-67 branch 2 times, most recently from b76fdb2 to db40f38 Compare July 28, 2025 14:04
@fjammes
Copy link
Copy Markdown
Contributor Author

fjammes commented Jul 28, 2025

Hi @LucaCanali , I am trying to fix a minor error in e2e test in Github Actions (it runs fine on a regular commit but not on a PR). Could you please approve my 2 workflows?

As you can see it works fine on a regular commit push: https://github.com/k8s-school/sparkMeasure/actions/runs/16571225806/job/46863741443
but the branch name is not managed the same way in git in a PR and this crashes the e2e tests. I'm currently trying to fix this.

@fjammes
Copy link
Copy Markdown
Contributor Author

fjammes commented Jul 29, 2025

Hi @LucaCanali

Would you mind re-triggering the tests on the PR?
It's a bit tricky for me to test on my side because the bug only seems to happen on the PR itself, not on regular commits.

I even created a fake PR on my own repo to simulate the scenario and everything went fine there:
k8s-school#1
— so I'm hoping it'll also work sparkMeasure official repository.

Thanks!

@fjammes
Copy link
Copy Markdown
Contributor Author

fjammes commented Jul 29, 2025

Hi @LucaCanali,

All CI tests have passed. Could you please complete your review and then merge?
Let me know if you'd like to have a short meeting so I can walk you through what the code is doing.

Thanks!

Best,
Fabrice

Copy link
Copy Markdown
Owner

@LucaCanali LucaCanali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fjammes for all the work on this.
A minor comment about Dockerfile, can you please add some header comment there on the general purpose of this Dockerfile and transalte the existing comments into English.

@LucaCanali
Copy link
Copy Markdown
Owner

Another point concerns the maintainability of this new component, including its code, Dockerfiles, and dependencies. Could we consider a strategy to make future troubleshooting and dependency updates easier, especially as new versions become available?

@fjammes
Copy link
Copy Markdown
Contributor Author

fjammes commented Jul 30, 2025

Hi @LucaCanali,

I'm happy to dedicate time to the long-term maintenance of this component.
To simplify usage and onboarding, I've just provided a one-liner script (e2e/run-all.sh) that builds the local Spark Measure container and runs it in Spark on Kubernetes—everything needed to get started on a Linux workstation.

Feel free to ask if you need anything else.

Best regards,
Fabrice

@LucaCanali LucaCanali merged commit fbc313a into LucaCanali:master Jul 30, 2025
5 checks passed
@LucaCanali
Copy link
Copy Markdown
Owner

LucaCanali commented Jul 30, 2025

I have merged the change however there seems to be a problem with the job Run spark-measure end-to-end tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants