Handle sync errors (set exit code accordingly) #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- syncandnotify() aborts early if mbsync or mpop fails - mailsync aborts early (exit code 1, before notmuch) if all syncs fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently mailsync exits with code 0 (success) even when mbsync/mpop fails to sync.
This PR makes it so it exits with failure (exit code 1) when all account sync attempts fail.
It also makes the syncandnotify() function return early when the sync fails instead of running through the rest of the function for no reason.
Use case:
When I run mailsync through torsocks, mbsync initially fails sometimes until it eventually works (not a mutt-wizard issue). So I thought I'd loop it until it succeeds. Problem: there was no direct way of knowing whether it failed or not.
Sure, this is a hack for a very specific use case, but I'm sure there are many more situations in which people expect a failure exit code upon failure.
I had to complicate the code a bit to consistently support multi account syncs, and it seemed reasonable to make it fail only if none succeeded.