Harden parser boundaries and Python packaging - #10
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (21)
📝 WalkthroughWalkthroughThe PR adds native error propagation, stricter CLI and decompression validation, document cleanup on constructor failures, Python wheel packaging, CI coverage, and Zig source formatting updates. ChangesZPDF validation and distribution
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant PythonZpdf
participant NativeExtraction
participant zpdf_last_error
Caller->>PythonZpdf: Call extraction or page helper
PythonZpdf->>NativeExtraction: Invoke native API
NativeExtraction->>zpdf_last_error: Set thread-local status
zpdf_last_error-->>PythonZpdf: Return error code
PythonZpdf-->>Caller: Return value or mapped exception
sequenceDiagram
participant PythonBuild
participant Zig
participant Wheel
participant IsolatedVenv
PythonBuild->>Zig: Locate or build zpdf shared library
Zig-->>PythonBuild: Return native library
PythonBuild->>Wheel: Copy library into zpdf package
Wheel-->>IsolatedVenv: Install platform wheel
IsolatedVenv->>Wheel: Import packaged zpdf library
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lulzx
marked this pull request as ready for review
August 11, 2026 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The robustness audit found an invalid-free in mixed page ranges, successful exit codes on failures, ambiguous FFI errors, incomplete constructor cleanup, stale native-library loading, and decompression paths that could exceed intended memory limits.
Validation
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests