fix(dashboard): restrict Path Finder "To" dropdown to reachable nodes#197
Open
ShresthSamyak wants to merge 1 commit into
Open
fix(dashboard): restrict Path Finder "To" dropdown to reachable nodes#197ShresthSamyak wants to merge 1 commit into
ShresthSamyak wants to merge 1 commit into
Conversation
The Dependency Path Finder modal listed every node in both the "From" and "To" selects, so users could pick a destination that was not reachable from the source and only learn "no path found" after clicking Find Path. Compute the reachable set from the chosen "From" node via the same undirected adjacency used by findPath (memoized on the graph), and filter the "To" dropdown to that set. Disable "To" until a source is picked, surface the reachable count, and clear a stale "To" selection when the source changes. Closes Lum1104#188
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates PathFinderModal to prevent users from selecting an unreachable destination node by precomputing reachability from the selected source and filtering the “To” dropdown accordingly.
Changes:
- Memoized an undirected adjacency map derived from the graph edges.
- Added a memoized BFS reachability set from the selected “From” node and filtered “To” candidates.
- Disabled/annotated the “To” selector when no source is chosen or when no destinations are reachable, and auto-cleared stale “To” selections.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+51
| const reachableFromSource = useMemo(() => { | ||
| if (!fromNodeId) return null; | ||
| const reachable = new Set<string>(); | ||
| const queue: string[] = [fromNodeId]; | ||
| reachable.add(fromNodeId); | ||
| while (queue.length > 0) { | ||
| const nodeId = queue.shift()!; | ||
| const neighbors = adjacency.get(nodeId) ?? []; | ||
| for (const n of neighbors) { | ||
| if (!reachable.has(n)) { | ||
| reachable.add(n); | ||
| queue.push(n); | ||
| } | ||
| } | ||
| } | ||
| reachable.delete(fromNodeId); | ||
| return reachable; | ||
| }, [fromNodeId, adjacency]); |
Comment on lines
+55
to
+60
| useEffect(() => { | ||
| if (toNodeId && reachableFromSource && !reachableFromSource.has(toNodeId)) { | ||
| setToNodeId(""); | ||
| setPath(null); | ||
| } | ||
| }, [reachableFromSource, toNodeId]); |
Comment on lines
+38
to
+40
| reachable.add(fromNodeId); | ||
| while (queue.length > 0) { | ||
| const nodeId = queue.shift()!; |
Owner
|
@codex review this |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findPathagree and the work isn't redone on every render.Before
Both selects listed every node. Pairs with no connecting path only failed after clicking Find Path, requiring the user to manually scan edges to find working destinations.
After
Once From is picked, To only shows nodes actually reachable from it —
N reachableis shown next to the label. Selecting To before From is disabled with a placeholder hinting at the order. If the source has no neighbors, To showsNo reachable nodes from sourceinstead of empty options.Notes
findPath(treats graph edges as undirected) so the filter and the BFS result can never disagree.Test plan
pnpm installpnpm --filter @understand-anything/dashboard exec tsc --noEmit— cleanpnpm --filter @understand-anything/dashboard build— succeedspnpm --filter @understand-anything/dashboard test— 42 passedpnpm lint— clean