Crop edges update simplified #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaehne
reviewed
Sep 17, 2025
JMPDI-coder
force-pushed
the
Lumispy-PR177
branch
2 times, most recently
from
6b408a5 to
6a2e712
Compare
jlaehne
reviewed
Sep 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JMPDI-coder
force-pushed
the
Lumispy-PR177
branch
2 times, most recently
from
a6ef337 to
026b09a
Compare
JMPDI-coder
force-pushed
the
Lumispy-PR177
branch
2 times, most recently
from
f51698c to
01652ee
Compare
JMPDI-coder
force-pushed
the
Lumispy-PR177
branch
from
01652ee to
e95bd09
Compare
jlaehne
reviewed
Oct 5, 2025
jlaehne
reviewed
Oct 14, 2025
jlaehne
reviewed
Oct 14, 2025
jlaehne
reviewed
Oct 14, 2025
jlaehne
reviewed
Oct 14, 2025
JMPDI-coder
force-pushed
the
Lumispy-PR177
branch
2 times, most recently
from
c91b375 to
3d587f3
Compare
JMPDI-coder
force-pushed
the
Lumispy-PR177
branch
2 times, most recently
from
641f776 to
99ed835
Compare
JMPDI-coder
force-pushed
the
Lumispy-PR177
branch
from
f7ad503 to
b66d741
Compare
jlaehne
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the request to make #142 cleaner and separate the crop_ede function from other changes, this is the clean version of the PR, aiming to extend the functionality of crop_edges.
Since the original PR author became inactive, this PR continues the work of PR177 to address the same issue.
Progress of the PR
-Change implemented (can be split into several points),
-docstring updated (if appropriate),
-update user guide (if appropriate),
-added tests,
-added line to upcoming_changes
-added correct year
-added linebreaks
-added blank line
-added comment
-ready for review.