-
Notifications
You must be signed in to change notification settings - Fork 197
Adding Dependencies to Installation Docs #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, but it might be better to link the actual tools instead.
We also don't need either cargo
or xclip
.
- `cargo` | ||
- `xclip` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `cargo` | |
- `xclip` | |
- `rg` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand where the connection between cargo
and xclip
is. When I installed LunarVim with cargo
as a dependency, xclip
was still missing.
Sidenote: when the installer asks you for rust dependencies, it will install fd-find and ripgrep for you |
@kylo252 The installer uses |
I'm pretty sure it doesn't, as it didn't ask me when I installed the latest version, which lead to the referenced Issue. |
The thing is that you can install these through your package manager or something and never have to deal with
Maybe you missed it, since it's optional. |
Maybe I did, but the installer never asked me so I don't even now where I should've been looking. |
Which system did you say you were using? I know that Debian has some other |
While it may be optional, I think it's the most direct way to getting them installed. Also distros may have out of date versions of the software or like in Ubuntu, doesn't install the binary as There are also cases, like on macOS, where the package manager is unreliable and often comes with out of date software and in the case of Homebrew, it often compiles from source anyway. |
It's a bit more tricky with macOS and where to get cargo, see LunarVim/LunarVim#1021 (comment) |
I'm using Manjaro which initially lacks both |
In Debian, |
I wonder if LunarVim is even capable of finding that weird |
I'm always hesitant to how much additional processing I can do in the installer because it's a headache not being able to use basic bash features (e.g. associative arrays) on macOS 😢 see LunarVim/LunarVim@ I'd much rather stop trying to re-invent the wheel and instead use actual native tools per-platform for detecting dependencies. |
You can alias fdfind to fD, just follow the guide in the docs. |
But that's something the user has to do. It's obviously be much more convenient for the installation script to do that job.
I feel you. Your efforts are very much appreciated! |
If the user chooses to manually install all dependencies, I think they should do the job. Regarding the detection of dependencies, are we talking about only the *NIX systems? If so, I got a neat built in method that I use in my fish config. if command -v <the_command> &> /dev/null
do_stuff_if_command_is_found
else
do_something_else
end The fish code above should Posix compliant |
I don't think it's that easy to do with only user-level privileges. Hell, some users don't even have
Thank you ❤️
Ideally, your package manager should deal with this, because the alternative is very time-consuming when trying to create a cross-platform dependency-aware installer from scratch. |
So we'd need to publish LunarVim on all kinds of package managers? |
Only the most popular ones from each platform:
The alternative is that someone has to write that package manager just for lunarvim 😞 |
What about Arch? |
Arch uses PKGBUILD. |
closes LunarVim#2028
There is probably a lot more to be added here but this is at least a start.