feat: nanoGPT implementation using Reactant#1062
Draft
Conversation
844a274 to
d2e7299
Compare
f4504bc to
9b97721
Compare
9b97721 to
6359fdb
Compare
386963b to
2dc6742
Compare
24e71cd to
0103f95
Compare
Contributor
Benchmark Results (ASV)
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
b508bb4 to
f64885f
Compare
f9cd522 to
1d6fe91
Compare
1d6fe91 to
fdd23e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit fdd23e2 to get more accurate results.
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
===========================================
- Coverage 82.53% 67.64% -14.89%
===========================================
Files 168 154 -14
Lines 6957 6408 -549
===========================================
- Hits 5742 4335 -1407
- Misses 1215 2073 +858 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs
NNlib.gathersupport in Reactant: feat: partial NNlib.gather support + better indexing support EnzymeAD/Reactant.jl#252NNlib.make_causal_mask: feat: add support for NNlib make causal mask EnzymeAD/Reactant.jl#249dynamic_gatherxref Jmp/scatter gather EnzymeAD/Enzyme-JAX#142