Skip to content

ci(docs): update cpu builds to use default gh actions#1569

Merged
avik-pal merged 10 commits intomainfrom
ap/doc_building_on_ghactions
Nov 22, 2025
Merged

ci(docs): update cpu builds to use default gh actions#1569
avik-pal merged 10 commits intomainfrom
ap/doc_building_on_ghactions

Conversation

@avik-pal
Copy link
Member

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the continuous integration process for documentation builds within Buildkite. It specifically removes the CPU-based documentation tutorial builds from Buildkite, as indicated by the title's intention to migrate them to GitHub Actions. Concurrently, it establishes a new, dedicated Buildkite pipeline for CUDA-based documentation tutorials, leading to a more modular and streamlined CI setup.

Highlights

  • Documentation CI Refactoring: The Buildkite CI configuration for documentation builds has been restructured for better organization.
  • CPU Build Relocation: Dedicated CPU tutorial build steps have been removed from the Buildkite pipeline, aligning with the intent to migrate them to default GitHub Actions.
  • CUDA Build Isolation: A new Buildkite configuration file, .buildkite/cuda_tutorials.yml, has been introduced to exclusively manage the CUDA documentation tutorial builds.
  • Main Pipeline Simplification: The primary Buildkite pipeline (.buildkite/pipeline.yml) has been updated to remove references to the old documentation build process, streamlining its definition.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/Documentation.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the documentation build process, intending to move CPU-based builds to GitHub Actions. It removes the comprehensive Buildkite documentation pipeline and introduces a new cuda_tutorials.yml file. However, these changes effectively disable all documentation builds on Buildkite since the triggers in pipeline.yml are removed and the new file is not used. My review highlights a critical FIXME in the new file that forces a draft build and must be removed before merging. I have also noted some latent issues in a commented-out build step that could cause future failures.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

Benchmark Results (Julia v1.11)

Time benchmarks
main a43314b... main / a43314b...
basics/MHA 4.14 ± 0.31 μs 4.3 ± 1.6 μs 0.963 ± 0.37
basics/MHA (first run) 4.41 ± 0.55 μs 4.23 ± 0.34 μs 1.04 ± 0.16
basics/MHA reactant 0.0654 ± 0.0076 ms 0.065 ± 0.0055 ms 1 ± 0.14
basics/MHA reactant (comp + run) 0.15 ± 0.0035 s 0.152 ± 0.0036 s 0.992 ± 0.033
basics/conv 12.8 ± 13 μs 18.4 ± 13 μs 0.694 ± 0.87
basics/conv (first run) 10.5 ± 2.7 μs 10.3 ± 0.64 μs 1.02 ± 0.27
basics/conv reactant 0.0537 ± 0.0028 ms 0.0521 ± 0.0027 ms 1.03 ± 0.076
basics/conv reactant (comp + run) 0.103 ± 0.0044 s 0.103 ± 0.0033 s 1 ± 0.053
basics/dense 0.181 ± 0.01 μs 0.18 ± 0.01 μs 1.01 ± 0.079
basics/dense (first run) 0.2 ± 0.001 μs 0.2 ± 0.001 μs 1 ± 0.0071
basics/dense reactant 0.0493 ± 0.0019 ms 0.0499 ± 0.0037 ms 0.987 ± 0.082
basics/dense reactant (comp + run) 0.0843 ± 0.003 s 0.0849 ± 0.0028 s 0.993 ± 0.048
time_to_load 0.904 ± 0.016 s 0.915 ± 0.016 s 0.988 ± 0.025
Memory benchmarks
main a43314b... main / a43314b...
basics/MHA 0.087 k allocs: 6.05 kB 0.087 k allocs: 6.05 kB 1
basics/MHA (first run) 0.087 k allocs: 6.05 kB 0.087 k allocs: 6.05 kB 1
basics/MHA reactant 19 allocs: 0.578 kB 19 allocs: 0.578 kB 1
basics/MHA reactant (comp + run) 18 k allocs: 1.28 MB 18 k allocs: 1.28 MB 1
basics/conv 0.038 k allocs: 5.12 kB 0.038 k allocs: 5.12 kB 1
basics/conv (first run) 0.038 k allocs: 5.12 kB 0.038 k allocs: 5.12 kB 1
basics/conv reactant 15 allocs: 0.438 kB 15 allocs: 0.438 kB 1
basics/conv reactant (comp + run) 6.14 k allocs: 0.723 MB 6.14 k allocs: 0.723 MB 1
basics/dense 2 allocs: 0.109 kB 2 allocs: 0.109 kB 1
basics/dense (first run) 2 allocs: 0.109 kB 2 allocs: 0.109 kB 1
basics/dense reactant 15 allocs: 0.422 kB 15 allocs: 0.422 kB 1
basics/dense reactant (comp + run) 5.9 k allocs: 0.706 MB 5.9 k allocs: 0.706 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@avik-pal avik-pal force-pushed the ap/doc_building_on_ghactions branch 4 times, most recently from 8dc57c8 to fefe081 Compare November 22, 2025 05:07
@avik-pal avik-pal force-pushed the ap/doc_building_on_ghactions branch from fefe081 to bf9c65c Compare November 22, 2025 05:13
@avik-pal avik-pal force-pushed the ap/doc_building_on_ghactions branch 3 times, most recently from 41d7cf8 to e0db0c1 Compare November 22, 2025 18:20
@avik-pal avik-pal force-pushed the ap/doc_building_on_ghactions branch from e0db0c1 to a43314b Compare November 22, 2025 18:21
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.10%. Comparing base (f593c26) to head (a43314b).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f593c26) and HEAD (a43314b). Click for more details.

HEAD has 48 uploads less than BASE
Flag BASE (f593c26) HEAD (a43314b)
69 21
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1569       +/-   ##
===========================================
- Coverage   82.56%   68.10%   -14.47%     
===========================================
  Files         170      170               
  Lines        7032     7020       -12     
===========================================
- Hits         5806     4781     -1025     
- Misses       1226     2239     +1013     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@avik-pal avik-pal merged commit 7606373 into main Nov 22, 2025
42 of 43 checks passed
@avik-pal avik-pal deleted the ap/doc_building_on_ghactions branch November 22, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant