ci(docs): update cpu builds to use default gh actions#1569
Conversation
Summary of ChangesHello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the continuous integration process for documentation builds within Buildkite. It specifically removes the CPU-based documentation tutorial builds from Buildkite, as indicated by the title's intention to migrate them to GitHub Actions. Concurrently, it establishes a new, dedicated Buildkite pipeline for CUDA-based documentation tutorials, leading to a more modular and streamlined CI setup. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the documentation build process, intending to move CPU-based builds to GitHub Actions. It removes the comprehensive Buildkite documentation pipeline and introduces a new cuda_tutorials.yml file. However, these changes effectively disable all documentation builds on Buildkite since the triggers in pipeline.yml are removed and the new file is not used. My review highlights a critical FIXME in the new file that forces a draft build and must be removed before merging. I have also noted some latent issues in a commented-out build step that could cause future failures.
Benchmark Results (Julia v1.11)Time benchmarks
Memory benchmarks
|
8dc57c8 to
fefe081
Compare
fefe081 to
bf9c65c
Compare
41d7cf8 to
e0db0c1
Compare
e0db0c1 to
a43314b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1569 +/- ##
===========================================
- Coverage 82.56% 68.10% -14.47%
===========================================
Files 170 170
Lines 7032 7020 -12
===========================================
- Hits 5806 4781 -1025
- Misses 1226 2239 +1013 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.