Skip to content

test: Metal test now works #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avik-pal merged 1 commit into from
Dec 5, 2025
Merged

test: Metal test now works #1581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/WeightInitializers/test/initializers_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ end

v = kaiming_normal(rng, n_in, n_out)
σ2 = sqrt(2 / n_out)
@test 0.9σ2 < std(v) < 1.1σ2 broken = backend in ["oneapi", "metal"]
@test 0.9σ2 < std(v) < 1.1σ2 broken = backend in ["oneapi"]
end

# Type
Expand Down
2 changes: 1 addition & 1 deletion lib/WeightInitializers/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const EXTRA_PKGS = PackageSpec[]
(BACKEND_GROUP == "all" || BACKEND_GROUP == "amdgpu") &&
push!(EXTRA_PKGS, PackageSpec(; name="AMDGPU"))
(BACKEND_GROUP == "all" || BACKEND_GROUP == "metal") &&
push!(EXTRA_PKGS, PackageSpec("Metal"))
push!(EXTRA_PKGS, PackageSpec(; name="Metal", version="1.9"))
Copy link

@gemini-code-assist gemini-code-assist bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning the Metal package to the exact version 1.9 might be too restrictive and could prevent your test environment from receiving important non-breaking bug fixes or performance improvements in future patch releases. It's generally better to allow for compatible updates.

Consider using a caret ^ for the version specifier, like version="^1.9". This will allow any version from 1.9.0 up to (but not including) 2.0.0, following semantic versioning. This makes your test setup more robust and less likely to require manual updates for minor package releases.

    push!(EXTRA_PKGS, PackageSpec(; name="Metal", version="^1.9"))

(BACKEND_GROUP == "all" || BACKEND_GROUP == "oneapi") &&
push!(EXTRA_PKGS, PackageSpec("oneAPI"))

Expand Down
Loading