Fix isbits type support for GPU device transfer#1587
Merged
Conversation
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken support for isbits types movement to GPU
Fix isbits type support for GPU device transfer
Dec 8, 2025
🧪 CI InsightsHere's what we observed from your CI run for 6cd1e8e. 🟢 All jobs passed!But CI Insights is watching 👀 |
avik-pal
reviewed
Dec 8, 2025
Comment on lines
353
to
362
| function array_adapt( | ||
| f::F, ::Type{aType}, ::Type{Missing}, x::AbstractArray{T} | ||
| ) where {F,aType,T} | ||
| isbitstype(T) || error( | ||
| "Cannot move array with element type `$(T)` to device. Element type must be an " * | ||
| "`isbits` type (e.g., Number, Char, or custom immutable struct with only " * | ||
| "`isbits` fields).", | ||
| ) | ||
| return f(x) | ||
| end |
Member
There was a problem hiding this comment.
@copilot Number/AbstractChar are isbitstype, we can remove the old dispatches
Contributor
Author
There was a problem hiding this comment.
Removed the redundant dispatches for Number and AbstractChar types. They're now handled by the fallback methods since they're isbits types. Kept only the specialized methods for AbstractFloat and Complex{<:AbstractFloat} for type conversion. (commit 0ae7ae4)
Number and AbstractChar are isbits types and are now handled by the
fallback methods. Only AbstractFloat and Complex{<:AbstractFloat} keep
specialized methods for type conversion when a specific type parameter
is provided.
Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Added explicit methods for Missing and Nothing type parameters with AbstractFloat and Complex arrays to avoid method ambiguity with the general isbits fallback. This maintains full backward compatibility including type conversion for any type parameter with float arrays. Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Clarified that specialized methods for AbstractFloat/Complex are for avoiding ambiguity and enabling type conversion, and improved fallback comment to use concrete type examples (Int32) instead of abstract types (Number) to avoid confusion. Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
avik-pal
reviewed
Dec 8, 2025
lib/MLDataDevices/src/internal.jl
Outdated
Comment on lines
318
to
320
| "Cannot move array with element type `$(T)` to device. Element type must be an " * | ||
| "`isbits` type (e.g., Number, Char, or custom immutable struct with only " * | ||
| "`isbits` fields).", |
Contributor
Benchmark Results (Julia v1.11)Time benchmarks
Memory benchmarks
|
Replace string concatenation operator (*) with backslash line continuation (\) in error messages for better Julia style. Co-authored-by: avik-pal <30564094+avik-pal@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to fix isbits types movement to GPU
array_adaptimplementation ininternal.jlisbitstypes inarray_adaptisbitstypes movementOriginal prompt
isbitstypes movement #1586💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.