Skip to content

docs: fix docs build#1594

Merged
avik-pal merged 1 commit intomainfrom
ap/fix_docs_build2
Dec 9, 2025
Merged

docs: fix docs build#1594
avik-pal merged 1 commit intomainfrom
ap/fix_docs_build2

Conversation

@avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 9, 2025

No description provided.

@avik-pal avik-pal merged commit cfc8c09 into main Dec 9, 2025
6 of 9 checks passed
@avik-pal avik-pal deleted the ap/fix_docs_build2 branch December 9, 2025 18:00
@gemini-code-assist
Copy link

Summary of Changes

Hello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve issues with the documentation build process. It includes an update to the list of available neural network activation functions by adding 'gelu_sigmoid' and adjusts the configuration for the 'SimpleChains' tutorial, which is a common step to ensure the documentation compiles without errors.

Highlights

  • Documentation Update: Added 'gelu_sigmoid' to the list of neural network activation functions in the 'ActivationFunctions.md' documentation file, ensuring the documentation is up-to-date with available functions.
  • Tutorial Configuration Adjustment: Modified the 'tutorials.jl' file to change the 'SimpleChains' tutorial's configuration, specifically setting its third parameter from 'true' to 'false', likely to address a build issue or temporarily disable its execution during the documentation build process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the documentation build. It does so by adding gelu_sigmoid to the list of activation functions and disabling the SimpleChains tutorial. My review includes a suggestion to improve the ordering of activation functions for better readability and a correction for the device type of the disabled tutorial. It would be beneficial to investigate the root cause of the SimpleChains tutorial failure and re-enable it in a future change.

Comment on lines 40 to 42
gelu_tanh
gelu_sigmoid
gelu_erf

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it would be good to keep the list of activation functions sorted alphabetically. The gelu variants seem to be out of order.

Suggested change
gelu_tanh
gelu_sigmoid
gelu_erf
gelu_erf
gelu_sigmoid
gelu_tanh

("PolynomialFitting", "CUDA", true),
("SimpleRNN", "CUDA", true),
("SimpleChains", "CUDA", true),
("SimpleChains", "CUDA", false),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The SimpleChains tutorial appears to be CPU-based, as indicated by Reactant.set_default_backend("cpu") in examples/SimpleChains/main.jl. It should be marked as "CPU" instead of "CUDA". While disabling it fixes the build for now, please correct the device type. It is also recommended to investigate why this tutorial is failing and re-enable it for the correct device (CPU) in a follow-up PR.

    ("SimpleChains",            "CPU",   false),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant