Skip to content

fix: temporarily disable precompile workloads for reactant#1628

Merged
avik-pal merged 1 commit intomainfrom
ap/disable_reactant_precomp
Jan 14, 2026
Merged

fix: temporarily disable precompile workloads for reactant#1628
avik-pal merged 1 commit intomainfrom
ap/disable_reactant_precomp

Conversation

@avik-pal
Copy link
Member

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @avik-pal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary fix by disabling precompile workloads specifically for the ReactantExt extension. This change aims to resolve an underlying issue, likely related to compilation or startup, by preventing the execution of these workloads. A minor version bump accompanies this fix, indicating a small, non-breaking change.

Highlights

  • Version Bump: The project version in Project.toml has been updated from 1.29.1 to 1.29.2.
  • Reactant Extension Modification: The precompile_workloads.jl file is now commented out in ext/ReactantExt/ReactantExt.jl, effectively disabling its inclusion.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables precompile workloads for the reactant extension by commenting out an include statement, and it also increments the package version. My review provides a suggestion to make this temporary change more explicit for better long-term maintainability. Instead of simply commenting out the line, I recommend wrapping it in an if false block. This clearly signals the temporary nature of the change and makes it easier to find and revert in the future.

include("batched_jacobian.jl")

include("precompile_workloads.jl")
# include("precompile_workloads.jl")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Commenting out code can make it unclear why the change was made and whether it's temporary. This can be easily overlooked or forgotten in the future.

A more explicit way to temporarily disable this would be to wrap it in an if false block with a comment. This makes the intention clear and the block is easily searchable for future cleanup.

if false # Temporarily disable precompile workloads for reactant
    include("precompile_workloads.jl")
end

@github-actions
Copy link
Contributor

Benchmark Results (Julia v1.11)

Time benchmarks
main fe2824d... main / fe2824d...
basics/MHA 4.22 ± 1.6 μs 5.76 ± 2.9 μs 0.732 ± 0.46
basics/MHA (first run) 4.33 ± 0.4 μs 4.54 ± 0.63 μs 0.954 ± 0.16
basics/MHA reactant 0.0634 ± 0.0036 ms 0.0589 ± 0.0035 ms 1.08 ± 0.088
basics/MHA reactant (comp + run) 0.168 ± 0.0038 s 0.169 ± 0.0027 s 0.998 ± 0.028
basics/conv 9.87 ± 1.5 μs 11.2 ± 17 μs 0.88 ± 1.3
basics/conv (first run) 10.3 ± 0.63 μs 10.2 ± 0.57 μs 1.01 ± 0.084
basics/conv reactant 0.051 ± 0.0029 ms 0.0503 ± 0.0021 ms 1.01 ± 0.073
basics/conv reactant (comp + run) 0.126 ± 0.0041 s 0.126 ± 0.0034 s 0.995 ± 0.042
basics/dense 0.181 ± 0.01 μs 0.18 ± 0.01 μs 1.01 ± 0.079
basics/dense (first run) 0.2 ± 0.001 μs 0.201 ± 0.01 μs 0.995 ± 0.05
basics/dense reactant 0.0471 ± 0.0019 ms 0.048 ± 0.0021 ms 0.981 ± 0.059
basics/dense reactant (comp + run) 0.107 ± 0.0038 s 0.107 ± 0.0033 s 1 ± 0.047
time_to_load 0.904 ± 0.018 s 0.88 ± 0.01 s 1.03 ± 0.023
Memory benchmarks
main fe2824d... main / fe2824d...
basics/MHA 0.087 k allocs: 6.05 kB 0.087 k allocs: 6.05 kB 1
basics/MHA (first run) 0.087 k allocs: 6.05 kB 0.087 k allocs: 6.05 kB 1
basics/MHA reactant 19 allocs: 0.578 kB 19 allocs: 0.578 kB 1
basics/MHA reactant (comp + run) 18.2 k allocs: 1.71 MB 18.2 k allocs: 1.71 MB 1
basics/conv 0.038 k allocs: 5.12 kB 0.038 k allocs: 5.12 kB 1
basics/conv (first run) 0.038 k allocs: 5.12 kB 0.038 k allocs: 5.12 kB 1
basics/conv reactant 15 allocs: 0.438 kB 15 allocs: 0.438 kB 1
basics/conv reactant (comp + run) 6.37 k allocs: 1.16 MB 6.4 k allocs: 1.16 MB 0.999
basics/dense 2 allocs: 0.109 kB 2 allocs: 0.109 kB 1
basics/dense (first run) 2 allocs: 0.109 kB 2 allocs: 0.109 kB 1
basics/dense reactant 15 allocs: 0.422 kB 15 allocs: 0.422 kB 1
basics/dense reactant (comp + run) 6.05 k allocs: 1.14 MB 6.05 k allocs: 1.14 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.97%. Comparing base (1393c5e) to head (fe2824d).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1393c5e) and HEAD (fe2824d). Click for more details.

HEAD has 23 uploads less than BASE
Flag BASE (1393c5e) HEAD (fe2824d)
52 29
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
- Coverage   81.96%   73.97%   -8.00%     
==========================================
  Files         173      173              
  Lines        7208     7177      -31     
==========================================
- Hits         5908     5309     -599     
- Misses       1300     1868     +568     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@avik-pal avik-pal merged commit c1a72f6 into main Jan 14, 2026
45 of 46 checks passed
@avik-pal avik-pal deleted the ap/disable_reactant_precomp branch January 14, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant