Skip to content

Fix nested list in buildInputs#91

Open
Squamto wants to merge 1 commit into
Lxtharia:devfrom
Squamto:dev
Open

Fix nested list in buildInputs#91
Squamto wants to merge 1 commit into
Lxtharia:devfrom
Squamto:dev

Conversation

@Squamto

@Squamto Squamto commented Jun 2, 2026

Copy link
Copy Markdown

Fixes #90

@Lxtharia

Lxtharia commented Jun 2, 2026

Copy link
Copy Markdown
Owner

If anyone can give me an approval that this works, I can merge this.

@Aozora-Wings feel free to test this :)

@Artturin Artturin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in mkDerivation conditional values shouldn't (usually) go in // because that doesn't perform deep merging and is a footgun for the future when others add args before // and they get overriden.

When you see a mkDerivation ({} // optionalAttrs x {}) in nixpkgs it's usually because something had to be fixed but doing it properly would have caused too many rebuilds

Comment thread flake.nix
Comment thread flake.nix
@Squamto

Squamto commented Jun 10, 2026

Copy link
Copy Markdown
Author

Okay thanks for the insight.
I initially debated using optionals and optionalString, but thought optionalAttrs looks like a cleaner solution, especially because I did not want to override any default buildPhase with nothing in the case there is no custom splash.
I will implement the proposed solution, when I am back home later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nix 26.05 buildInputs deprecation warning

3 participants