Skip to content

Avoid displaying the live-metrics icon if not enabled #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented May 7, 2025

Add a flag to make sure we do not display the icon if the functionality is NOT enabled...

Backend Changes:

  • Added a new property is_live_metrics_enabled to the InitConfig class to track whether live metrics are enabled. (app/Http/Resources/GalleryConfigs/InitConfig.php)
  • Updated the set_supporter_properties method in InitConfig to initialize is_live_metrics_enabled based on the configuration value live_metrics_enabled and the is_se_enabled flag. (app/Http/Resources/GalleryConfigs/InitConfig.php)

Localization Changes:

  • Added a preview_text field under the metrics section in language files to display a preview message for live metrics. This change was made across multiple language files, including but not limited to ar, cz, de, en, fr, ja, ru, and zh_CN. [1] [2] [3] [4] [5]

These changes ensure that the live metrics feature is properly integrated into the backend logic and is supported with localized text for a global audience.

@ildyria ildyria requested a review from a team as a code owner May 7, 2025 11:05
Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (312eb31) to head (535230a).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label May 7, 2025
@ildyria ildyria force-pushed the fix-missing-toggle branch from bb18ff5 to 9f3a880 Compare May 9, 2025 06:17
@ildyria ildyria force-pushed the fix-missing-toggle branch from 9f3a880 to 535230a Compare May 9, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant