build(deps): bump actions/checkout from 5 to 6 in the action-dependencies group#1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
3d2bf3e to
9b0915d
Compare
6cfc0ca to
9c8b423
Compare
Bumps the action-dependencies group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: action-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
9c8b423 to
135382f
Compare
Contributor
Author
|
Looks like actions/checkout is updatable in another way, so this is no longer needed. |
matsuzaka-yuki
pushed a commit
that referenced
this pull request
Jun 9, 2026
…nce (#153) Found 4 distinct bugs in the boot_patch.sh that are inherited from the APatch script this fork is based on: 1. Line 97 (flash guard): `[ -b X ] || [ -c X ] && [ -f Y ]` is parsed as `[ -b X ] || ( [ -c X ] && [ -f Y ] )` by every POSIX sh on Android. When BOOTIMAGE is a block device the `[ -f new-boot.img ]` test was never evaluated, so the script would attempt to flash even when the repack step had silently failed and the output file was missing. 2. Line 90 (repack error check): `if [ $? -ne 0 ]` was checking the exit code of the previous `if` block (always 0 for the success branch) rather than the `kptools repack` exit code. This meant repack failures were silently ignored. 3. Line 51: `exit $?` after the unpack step was redundant but harmless; changed to `exit $patch_rc` for consistency. 4. Line 78: same as #3 for the patch step. Fix: - Capture `./kptools repack` exit code into `repack_rc` immediately after it runs, then check `$repack_rc` against 0. - Replace `exit $?` with `exit $patch_rc` / `exit $repack_rc` for clarity and to make the rc unambiguous. - Replace the flash guard with a nested `if` so both conditions (`[-b|-c] BOOTIMAGE` AND `[ -f new-boot.img ]`) are required, with a clear error if the output file is missing. The same flash-bug and the repack-rc bug are present in the upstream APatch script. Tested on a Pixel 6 / OnePlus 9 / S22 in Zhanfg/KPatch-Next-Module (PR #1) for the past 2 weeks. This is the most actively maintained APatch fork (LyraVoid/FolkPatch, 809★), so fixing it here benefits the most users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the action-dependencies group with 1 update: actions/checkout.
Updates
actions/checkoutfrom 5 to 6Release notes
Sourced from actions/checkout's releases.
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
1af3b93update readme/changelog for v6 (#2311)71cf226v6-beta (#2298)069c695Persist creds to a separate file (#2286)ff7abcdUpdate README to include Node.js 24 support details and requirements (#2248)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions