fix: improve ReplayGain analysis accuracy and robustness#48
Merged
Conversation
- Add filter coefficients for all 12 sample rates from original mp3gain (96000, 88200, 64000, 48000, 44100, 32000, 24000, 22050, 16000, 12000, 11025, 8000 Hz) instead of falling back to 44100 Hz for unsupported rates - Add denormal float prevention (1e-10 constant) to filter processing to avoid performance degradation on silent audio sections - Add bounds checking with checked_add/saturating_add in MP4 metadata parsing to prevent potential panics on malformed files Fixes #41, fixes #43, fixes #47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three issues related to ReplayGain analysis and MP4 metadata handling:
Issue #41: Limited sample rate support
Issue #43: Missing denormal float prevention
1e-10constant to filter processing to prevent denormal float slowdownsIssue #47: Bounds checking for MP4 metadata parsing
checked_addandsaturating_addfor safer arithmeticTesting
References
Fixes #41
Fixes #43
Fixes #47