Fix invalid routing path due to spaces inside the json - #288
Open
omartijn wants to merge 1 commit into
Open
Conversation
In newer versions, urllib rejects paths containing control characters, which includes spaces. Since `json.dumps` adds spaces by default, this caused the request to be rejected locally, preventing routing from working. This change was tested on my device and works locally. Tested with the most recent version of osm-scout-server on SFOS 3.3.
Owner
|
Thanks for the PR & sorry for not checking this out earlier. Looks good to me & I should be able to test it in the next day or two. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In newer versions, urllib rejects paths containing control characters,
which includes spaces. Since
json.dumpsadds spaces by default, thiscaused the request to be rejected locally, preventing routing from
working.
This change was tested on my device and works locally. Tested with the
most recent version of osm-scout-server on SFOS 3.3.