Skip to content

Remove obsolete download_granule function#107

Merged
chuckwondo merged 1 commit intomainfrom
remove-obsolete-download-granule
Feb 27, 2025
Merged

Remove obsolete download_granule function#107
chuckwondo merged 1 commit intomainfrom
remove-obsolete-download-granule

Conversation

@chuckwondo
Copy link
Collaborator

I noticed that the download_granule function was not removed at the time that we shifted to directly reading from s3 instead of downloading files, so this PR simply removes it, along with related code.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@chuckwondo chuckwondo changed the title Remove obsolete download_granule functionk Remove obsolete download_granule function Feb 27, 2025
@chuckwondo chuckwondo requested a review from jjfrench February 27, 2025 16:43
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notebook's purpose was to compare granule download speeds when using different numbers of workers. Since we no longer download granules, this notebook is obsolete.

Copy link
Member

@jjfrench jjfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@chuckwondo chuckwondo merged commit fab11f7 into main Feb 27, 2025
7 checks passed
@chuckwondo chuckwondo deleted the remove-obsolete-download-granule branch February 27, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants