Open
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Walkthrough매칭 요청 거절 기능을 위한 API 엔드포인트를 추가하고, 그룹 리더의 거절 요청을 처리하는 서비스 로직을 구현했습니다. 거절 시 요청자와 리더의 상태를 업데이트하고 알림을 트리거합니다. Changes
Sequence DiagramsequenceDiagram
actor Client
participant GroupV3Controller
participant GroupV3Service
participant GroupValidator
participant GroupMemberRepository
participant AlarmService
participant Database
Client->>GroupV3Controller: PATCH /match-reject/{matchId}
GroupV3Controller->>GroupV3Service: rejectRequest(userId, matchId)
GroupV3Service->>GroupMemberRepository: getMatchSummary(matchId)
GroupMemberRepository->>Database: 쿼리 실행
Database-->>GroupMemberRepository: 매칭 요청 정보
GroupMemberRepository-->>GroupV3Service: requesterId 반환
GroupV3Service->>GroupValidator: 그룹 리더 검증
GroupValidator->>Database: 그룹 정보 조회
Database-->>GroupValidator: 그룹 데이터
GroupValidator-->>GroupV3Service: 검증 완료
GroupV3Service->>GroupMemberRepository: updateLeaderStatusPending(userId, groupId)
GroupMemberRepository->>Database: 리더 상태 PENDING_REQUEST로 업데이트
GroupV3Service->>GroupMemberRepository: updateMemberStatusFailed(requesterId, groupId)
GroupMemberRepository->>Database: 요청자 상태 MATCH_FAILED로 업데이트
GroupV3Service->>AlarmService: readAllAlarms(userId)
AlarmService->>Database: 알림 처리
GroupV3Service-->>GroupV3Controller: 완료
GroupV3Controller-->>Client: 200 OK (successWithNoData)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (4)
src/main/java/at/mateball/exception/code/BusinessErrorCode.java (1)
68-68: 에러 코드가 잘못된 섹션에 위치해 있습니다.
REQUEST_NOT_FOUND는HttpStatus.NOT_FOUND(404)를 사용하지만, 현재 "409 CONFLICT" 주석 섹션 아래에 배치되어 있습니다. 코드 가독성을 위해 "404 NOT FOUND" 섹션(Lines 51-60)으로 이동하세요.🔧 에러 코드 위치 수정
// 404 NOT FOUND TOKEN_NOT_FOUND(HttpStatus.NOT_FOUND, "요청에 해당하는 토큰이 존재하지 않습니다."), USER_NOT_FOUND(HttpStatus.NOT_FOUND, "존재하지 않는 사용자입니다."), GROUP_NOT_FOUND(HttpStatus.NOT_FOUND, "존재하지 않는 매칭입니다."), REQUESTER_NOT_FOUND(HttpStatus.NOT_FOUND, "존재하지 않는 요청자입니다."), GAME_NOT_FOUND(HttpStatus.NOT_FOUND, "존재하지 않는 경기입니다."), MATCH_REQUIREMENT_NOT_FOUND(HttpStatus.NOT_FOUND, "매칭 조건 정보가 존재하지 않습니다."), CHATTING_NOT_FOUND(HttpStatus.NOT_FOUND, "오픈채팅이 존재하지 않습니다."), ALARM_NOT_FOUND(HttpStatus.NOT_FOUND, "존재하지 않는 알림입니다."), NO_GAME_SCHEDULED(HttpStatus.NOT_FOUND, "선택한 날짜에 경기가 존재하지 않습니다."), + REQUEST_NOT_FOUND(HttpStatus.NOT_FOUND, "요청 정보를 찾을 수 없습니다."), // 409 CONFLICT DUPLICATED_NICKNAME(HttpStatus.CONFLICT, "중복된 닉네임입니다."), ... DUPLICATED_MATCH_REQUIREMENT(HttpStatus.CONFLICT, "이미 매칭 조건이 존재합니다."), - REQUEST_NOT_FOUND(HttpStatus.NOT_FOUND, "요청 정보를 찾을 수 없습니다."),🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/at/mateball/exception/code/BusinessErrorCode.java` at line 68, The enum constant REQUEST_NOT_FOUND in BusinessErrorCode is placed under the 409 CONFLICT section but uses HttpStatus.NOT_FOUND; move the REQUEST_NOT_FOUND entry into the 404 NOT FOUND section (the block that contains other NOT_FOUND codes) so it sits with other HttpStatus.NOT_FOUND entries; ensure the enum comma/semicolon formatting remains correct after relocating the REQUEST_NOT_FOUND constant.src/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryCustom.java (1)
87-87:updateMemberStatus와 중복되는 메서드입니다.Line 47에 이미 동일한 시그니처를 가진
updateMemberStatus(Long userId, Long groupId, int status)메서드가 존재합니다. 새로운updateStatus메서드를 추가하는 대신 기존 메서드를 재사용하는 것이 좋습니다.♻️ 기존 메서드 재사용 제안
- void updateStatus(Long userId, Long groupId, int status);서비스에서
groupMemberRepository.updateMemberStatus(...)를 직접 호출하세요.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryCustom.java` at line 87, The new method updateStatus(Long userId, Long groupId, int status) is a duplicate of the existing updateMemberStatus(Long userId, Long groupId, int status); remove the redundant updateStatus declaration from GroupMemberRepositoryCustom and update any callers to use updateMemberStatus(...) instead so the repository exposes only the single updateMemberStatus method; verify compile and run tests to ensure no remaining references to updateStatus.src/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryImpl.java (1)
867-873: 기존updateMemberStatus메서드와 중복됩니다.Lines 424-429의
updateMemberStatus메서드와 동일한 구현입니다. 중복 코드를 제거하고 기존 메서드를 재사용하세요.♻️ 중복 메서드 제거 제안
- `@Override` - public void updateStatus(Long userId, Long groupId, int status) { - queryFactory.update(groupMember) - .set(groupMember.status, status) - .where(groupMember.user.id.eq(userId), groupMember.group.id.eq(groupId)) - .execute(); - }인터페이스에서도
updateStatus선언을 제거하고, 서비스에서updateMemberStatus를 직접 사용하세요.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryImpl.java` around lines 867 - 873, The updateStatus method duplicates existing logic in updateMemberStatus; remove the redundant updateStatus implementation from GroupMemberRepositoryImpl and delete its declaration from the repository interface, then refactor callers to use updateMemberStatus(Long userId, Long groupId, int status) instead (locate methods by the names updateStatus and updateMemberStatus to update references).src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java (1)
330-332: 메서드 호출 불일치 - 중복 메서드 사용 중입니다.
updateLeaderStatusPending(Line 312)은groupMemberRepository.updateMemberStatus를 호출하고,updateMemberStatusFailed는groupMemberRepository.updateStatus를 호출합니다. 앞서 지적한 대로updateStatus는updateMemberStatus와 동일한 중복 메서드입니다.일관성을 위해 모두
updateMemberStatus를 사용하세요.♻️ 일관된 메서드 사용
private void updateMemberStatusFailed(Long userId, Long groupId) { - groupMemberRepository.updateStatus(userId, groupId, GroupMemberStatus.MATCH_FAILED.getValue()); + groupMemberRepository.updateMemberStatus(userId, groupId, GroupMemberStatus.MATCH_FAILED.getValue()); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java` around lines 330 - 332, The method updateMemberStatusFailed currently calls groupMemberRepository.updateStatus (a duplicate of updateMemberStatus); replace that call so updateMemberStatusFailed uses groupMemberRepository.updateMemberStatus(...) instead to match updateLeaderStatusPending and maintain consistent repository method usage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java`:
- Around line 330-332: The method updateMemberStatusFailed currently calls
groupMemberRepository.updateStatus (a duplicate of updateMemberStatus); replace
that call so updateMemberStatusFailed uses
groupMemberRepository.updateMemberStatus(...) instead to match
updateLeaderStatusPending and maintain consistent repository method usage.
In
`@src/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryCustom.java`:
- Line 87: The new method updateStatus(Long userId, Long groupId, int status) is
a duplicate of the existing updateMemberStatus(Long userId, Long groupId, int
status); remove the redundant updateStatus declaration from
GroupMemberRepositoryCustom and update any callers to use
updateMemberStatus(...) instead so the repository exposes only the single
updateMemberStatus method; verify compile and run tests to ensure no remaining
references to updateStatus.
In
`@src/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryImpl.java`:
- Around line 867-873: The updateStatus method duplicates existing logic in
updateMemberStatus; remove the redundant updateStatus implementation from
GroupMemberRepositoryImpl and delete its declaration from the repository
interface, then refactor callers to use updateMemberStatus(Long userId, Long
groupId, int status) instead (locate methods by the names updateStatus and
updateMemberStatus to update references).
In `@src/main/java/at/mateball/exception/code/BusinessErrorCode.java`:
- Line 68: The enum constant REQUEST_NOT_FOUND in BusinessErrorCode is placed
under the 409 CONFLICT section but uses HttpStatus.NOT_FOUND; move the
REQUEST_NOT_FOUND entry into the 404 NOT FOUND section (the block that contains
other NOT_FOUND codes) so it sits with other HttpStatus.NOT_FOUND entries;
ensure the enum comma/semicolon formatting remains correct after relocating the
REQUEST_NOT_FOUND constant.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 904fd88c-ac63-43b5-91e2-e6c55402967e
📒 Files selected for processing (6)
src/main/java/at/mateball/domain/group/api/controller/GroupV3Controller.javasrc/main/java/at/mateball/domain/group/core/service/GroupV3Service.javasrc/main/java/at/mateball/domain/groupmember/api/dto/GroupMatchSummaryRes.javasrc/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryCustom.javasrc/main/java/at/mateball/domain/groupmember/core/repository/querydsl/GroupMemberRepositoryImpl.javasrc/main/java/at/mateball/exception/code/BusinessErrorCode.java
hyeeum
force-pushed
the
feat/#247-reject-request-v3-migration
branch
from
57a0c8b to
bba7f07
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java (1)
47-55:⚠️ Potential issue | 🔴 Critical컴파일 오류: 누락된 필드 선언 및 import
이 코드에는 두 가지 컴파일 오류가 있습니다:
alarmService필드 누락: Line 370에서alarmService.readAllAlarms(userId)를 호출하지만, 클래스에AlarmService필드가 선언되어 있지 않습니다.
Optionalimport 누락: Line 364에서Optional.ofNullable()을 사용하지만,java.util.Optional이 import되어 있지 않습니다.🐛 필드 및 import 추가 제안
import java.time.LocalDate; import java.util.Collections; import java.util.Comparator; import java.util.List; import java.util.Map; +import java.util.Optional; import java.util.stream.Collectors;private final GroupRepository groupRepository; private final GroupRequestService groupRequestService; private final GroupMemberRepository groupMemberRepository; private final GroupV3RepositoryCustom groupV3RepositoryCustom; private final GroupMatchAggregator groupMatchAggregator; private final MatchImageAssembler matchImageAssembler; private final MatchingScoreCalculator matchingScoreCalculator; private final FileStorage fileStorage; private final GroupExecutorV3 groupExecutor; + private final AlarmService alarmService;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java` around lines 47 - 55, Add a missing AlarmService field to GroupV3Service and import java.util.Optional: declare a final AlarmService alarmService and have it injected/initialized alongside the other dependencies in the GroupV3Service constructor so calls like alarmService.readAllAlarms(userId) compile, and add the import statement for Optional (java.util.Optional) so Optional.ofNullable(...) resolves.
🧹 Nitpick comments (1)
src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java (1)
341-352: 미사용 반환값:getValidatedGroup
getValidatedGroup메서드가Group객체를 반환하지만,rejectRequest의 호출부(Line 360)에서 반환값을 사용하지 않습니다. 반환값이 필요 없다면void로 변경하는 것이 명확합니다.♻️ void 반환 타입으로 변경 제안
- private Group getValidatedGroup(Long userId, Long groupId) { + private void validateGroupLeader(Long userId, Long groupId) { Group group = groupRepository.findById(groupId) .orElseThrow(() -> new BusinessException(BusinessErrorCode.GROUP_NOT_FOUND)); GroupValidator.validate(group); if (!group.getLeader().getId().equals(userId)) { throw new BusinessException(BusinessErrorCode.NOT_MATCH_LEADER); } - - return group; }호출부도 함께 수정:
- getValidatedGroup(userId, matchId); + validateGroupLeader(userId, matchId);Also applies to: 360-360
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java` around lines 341 - 352, The method getValidatedGroup in GroupV3Service returns a Group but its return value is unused by callers like rejectRequest; change getValidatedGroup to return void (remove the Group return and return statement) and keep its validation and leader-check logic, then update its callers (e.g., rejectRequest) to call getValidatedGroup(...) without expecting a return value or assignment; search for any other usages of getValidatedGroup and update their call sites accordingly, and adjust the method signature and any references/imports or tests that expect a Group from getValidatedGroup.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java`:
- Around line 47-55: Add a missing AlarmService field to GroupV3Service and
import java.util.Optional: declare a final AlarmService alarmService and have it
injected/initialized alongside the other dependencies in the GroupV3Service
constructor so calls like alarmService.readAllAlarms(userId) compile, and add
the import statement for Optional (java.util.Optional) so
Optional.ofNullable(...) resolves.
---
Nitpick comments:
In `@src/main/java/at/mateball/domain/group/core/service/GroupV3Service.java`:
- Around line 341-352: The method getValidatedGroup in GroupV3Service returns a
Group but its return value is unused by callers like rejectRequest; change
getValidatedGroup to return void (remove the Group return and return statement)
and keep its validation and leader-check logic, then update its callers (e.g.,
rejectRequest) to call getValidatedGroup(...) without expecting a return value
or assignment; search for any other usages of getValidatedGroup and update their
call sites accordingly, and adjust the method signature and any
references/imports or tests that expect a Group from getValidatedGroup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a6099de0-a0b7-4a4f-a872-e17e848367c2
📒 Files selected for processing (2)
src/main/java/at/mateball/domain/group/api/controller/GroupV3Controller.javasrc/main/java/at/mateball/domain/group/core/service/GroupV3Service.java
🚧 Files skipped from review as they are similar to previous changes (1)
- src/main/java/at/mateball/domain/group/api/controller/GroupV3Controller.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 이슈 번호
closed #247
✅ 어떻게 이슈를 해결했나요?
❤️ To 다진 / To 헤음
Summary by CodeRabbit
릴리스 노트