Initial MVP implementing a datastore for a common use case. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting work in
Added extra functions for readability and workflow
Allows 2 extensions read case ('json' and 'tsv')
…prope/2-add-filetype-selector add file type selector, loop over file extensions
Update Readme and .mlx
update .gitignore to contain .asv files
Add changes to toolbox - new layout
Update documentation
Update Readme
Openneuro import
Delete all old files
Collaborator
|
I have the same issues with this PR as with #3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the MVP features we landed on for the Participantwise datastore while maintaining full backward compatibility with existing code. The main enhancement is a Type dictionary system that enables clean, intuitive syntax for creating datastores.
Key Features Added
🎯 MVP Features Implemented
"Anatomical NIfTI","EEG EDF","Functional NIfTI","DWI","Fieldmap"ReadFcn,FileExtensions,FolderPathkeys(obj.Type)fileDatastore.read()in MVP mode (partially functional)