Fix -fno-rtti flag applied to C files causing build failure #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ninja build was failing because
-fno-rttiand-fno-exceptionsflags were applied to C files, generating warnings treated as errors.Changes
Modified
src/base.cmaketo apply C++-specific compiler flags only to C++ sources using CMake generator expressions:This prevents the compiler from issuing
command-line option '-fno-rtti' is valid for C++/D/ObjC++ but not for Cwarnings when building C source files.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.