remove locking behavior from ?solve #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required me to make some changes to how stuff is handled, as now we can't rely on the post being locked to make sure it's solved
Electrosolt
reviewed
Nov 18, 2024
src/main/java/com/diamondfire/helpbot/bot/events/ChannelUpdatedNameEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/com/diamondfire/helpbot/bot/command/impl/other/util/SolvedCommand.java
Show resolved
Hide resolved
Electrosolt
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving a post no longer locks it
Had to make some stupid extra changes just because now I can't just rely on the post being locked to confirm it's solved, also added some extra safeguards for making a post that has the properties of a solved one (and for renaming)