feat(contracts): implement contract dependency tracker module (#151) - #163
Merged
mijinummi merged 2 commits intoJun 17, 2026
Conversation
…ative-Production#151) - add DependencyTrackerModule under src/modules/contracts/dependencies/ - add ContractNode, DependencyGraph, RiskLevel interfaces - add DependencyTrackerService: registerContract, addDependency, getGraph (cycle-safe BFS traversal) and getAll with in-memory store - add DependencyTrackerController exposing REST endpoints: POST /contracts/dependencies/register POST /contracts/dependencies GET /contracts/dependencies GET /contracts/dependencies/graph/:address?chain= - add 20 unit tests covering happy paths, ConflictException, NotFoundException, risk propagation, and cycle-safety - register module in AppModule Closes MD-Creative-Production#151
Collaborator
|
Hi @Topmatrixmor2014 , well done for this effort, please kindly fix [Code Quality & Security / TypeScript Type Checking Failing |
- add 'jest' to tsconfig.json types array so tsc --noEmit resolves jest globals in spec files (fixes TypeScript type checking CI job) - enable build:backend in Dockerfile builder stage (was commented out) - fix COPY path from /app/src to /app/apps/backend/dist - fix CMD entrypoint to dist/apps/backend/src/main.js (fixes Docker Build Check CI job)
Contributor
Author
|
This has been resolved. Kindly confirm
…On Wed, Jun 17, 2026, 5:23 PM Muhammad Auwal ***@***.***> wrote:
*mijinummi* left a comment (MD-Creative-Production/Sentinel#163)
<#163 (comment)>
Hi @Topmatrixmor2014 <https://github.com/Topmatrixmor2014> , well done
for this effort, please kindly fix [Code Quality & Security / TypeScript
Type Checking Failing
—
Reply to this email directly, view it on GitHub
<#163?email_source=notifications&email_token=CBUXREBLOLQSICWWVJM7L4L5ALAWLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZTGI3TQOBVGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4732788569>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CBUXREEJFL75DYMKNQFFYW35ALAWLAVCNFSNUABGKJSXA33TNF2G64TZHMYTCMZWGQYDEMBWGM5US43TOVSTWNBWHA2TANBUGY3DHILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CBUXREGGR3YR4OYIMHC4NKL5ALAWLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZTGI3TQOBVGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/CBUXRED4YK76ZSYMA3VRVN35ALAWLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZTGI3TQOBVGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Topmatrixmor2014
force-pushed
the
feat/contract-dependency-tracker-151
branch
from
June 17, 2026 16:57
5886d38 to
24ab11c
Compare
Collaborator
|
LGTM! |
mijinummi
merged commit Jun 17, 2026
1d59e5c
into
MD-Creative-Production:main
18 of 22 checks passed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Contract Dependency Tracker module as requested in issue #151.
What was implemented
New module:
apps/backend/src/modules/contracts/dependencies/interfaces/dependency-tracker.interface.tsRiskLevel,ContractNode,ContractDependency,DependencyGraph,RegisterContractDto,AddDependencyDtodependency-tracker.service.tsdependency-tracker.controller.tsdependency-tracker.module.tsdependency-tracker.service.spec.tsREST endpoints
Key technical decisions
none → low → medium → high → critical).getGraphreduces across all nodes + edges and surfaces the maximum.Map<chain:address, ContractNode>keyed on lowercase address+chain, trivially swappable for a DB repository.Acceptance criteria
registerContract+addDependencygetGraphreturns full node list + adjacencypropagatedRiskfield surfaces worst-case risk in the subgraphTesting
Closes #151