-
Notifications
You must be signed in to change notification settings - Fork 853
StaticFetcher() Implementation + from_pdb() refactor #5436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jauy123
wants to merge
110
commits into
MDAnalysis:develop
Choose a base branch
from
jauy123:Fetcher_Class
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,424
−139
Open
Changes from 73 commits
Commits
Show all changes
110 commits
Select commit
Hold shift + click to select a range
e3bc2ae
Added TODO
jauy123 87a7b94
Added Pseudocode for Fetchers based on blog post
jauy123 ad044ef
updated private methods
jauy123 8fbd203
Added Dev Things
jauy123 c4c6b56
more dev stuff
jauy123 b921f53
More Dev stuff yay
jauy123 f76554e
More Dev stuff yay
jauy123 48e8925
Added workflow
jauy123 900ce8b
Added workflow for StaticFetcher.fetch()
jauy123 fc05684
Added more notes
jauy123 b609fd6
Reworked to used pooch functions instead of writing own
jauy123 93e777c
Works but clunky!
jauy123 dbd62be
Updated TEST.py
jauy123 f3837aa
Working single file fetch
jauy123 cefb95f
Tests to fix for tomorrow
jauy123 e175d6e
working test case
jauy123 41d52be
Working! Need to refactor
jauy123 1fb4857
Working! Need to refactor
jauy123 0b8b439
test for gh-ci.yaml
jauy123 3ad1d00
Added pooch Downloader Support
jauy123 15e4ff9
applied black
jauy123 b8de1eb
Created Test Suite
jauy123 9312486
Finalized code -- test still need to be written
jauy123 c4490b8
Made progressbar work
jauy123 d745faf
Github action working
jauy123 7b9281d
Repo guard removed?
jauy123 56ecac2
removed duplicate imports
jauy123 70628d8
added early docs
jauy123 bfe74b6
added header to tests
jauy123 000f15c
Docs can build now!
jauy123 0e14f47
docs
jauy123 414408b
fixed pytests
jauy123 a99c78a
added minor test
jauy123 a79fa78
Reforce github Actions
jauy123 2cc2723
added test for multiple hashes
jauy123 80b0988
made hashes a generator
jauy123 30e8eb6
made hashes an exclusive write
jauy123 497b400
finalized Tests
jauy123 da3087a
Applied black
jauy123 0ee322f
Moved to proper spot
jauy123 f140dce
Added enviornment variable override
jauy123 f127396
added variable to expected behaviors
jauy123 d3cda77
TESTs finally working!
jauy123 e01d95a
Merge branch 'develop' into Fetcher_Class
jauy123 7ae0b4c
More docs
jauy123 149d8b5
Post processing
jauy123 4532bf2
works with test
jauy123 b9edac0
removed Hash=None
jauy123 0a8d4d6
minor update
jauy123 1914650
minor docstring
jauy123 57af7d8
add gitignore
jauy123 47a1220
removed pytest.log
jauy123 3c76626
Applied black
jauy123 fb9676d
Removed weird files
jauy123 dcc07e0
removed junk output
jauy123 ae667f7
fixed docstring
jauy123 84bcf1d
formatting fetchers.py
jauy123 c77a86a
Fetchers now only downloaed requested_files
jauy123 1bcaaba
added auto to downloader arguement
jauy123 620978d
Removed StaticFetcher().db_path
jauy123 cf36767
Fixed and added docs to append_registry()
jauy123 75b058d
minor modifications
jauy123 608a4d7
done for the day
jauy123 673e982
some docs
jauy123 53b280d
Added ignore flag
jauy123 8e5cbcd
Applied black
jauy123 288e66a
fixed value error
jauy123 654bebf
working tests
jauy123 2dff5e9
Pre-AI review docstring
jauy123 c0548cb
refactor environment override
jauy123 e131b28
added version
jauy123 89367ad
Pass by hand
jauy123 db33242
updated regex
jauy123 25fe27d
allowed from_pdb() to accept strings
jauy123 8d386f3
getting test to work
jauy123 71b9826
added downloader stuff'
jauy123 d356da1
added exception
jauy123 2779a96
changed FILE1.txt content
jauy123 2bec26c
Changed content of TEST_FILE2
jauy123 4ed2553
changed content of TEST_FILE_3.txt
jauy123 4062c74
fixed test_static_fetcher.py
jauy123 f3c45dc
applied black
jauy123 e270abc
fixed typos
jauy123 f3d4bc8
renamed test
jauy123 eff8354
made servers.py a relative import
jauy123 6e89ff6
made temp server do a random port
jauy123 c626c2a
fixed mutable default arguement
jauy123 dfb0568
fixed typo
jauy123 4f8c8be
revert local impot
jauy123 891f8c9
readded variable for backwards compatiblity
jauy123 48e4bd3
applied black
jauy123 4715272
reenabled tests?
jauy123 0c427e7
applied monkeypatch
jauy123 519fe2e
Formalized Downloaders Test
jauy123 99f5d53
fixed pooch import
jauy123 4940428
added fetch(append_db=True)
jauy123 878e6a1
Added to replicate
jauy123 467cdf4
Merge remote-tracking branch 'upstream/develop' into Fetcher_Class
jauy123 423f7b5
Updated docs
jauy123 b550fe4
applied flake8
jauy123 d0e494e
applied flake8 where it made sense
jauy123 2d7c289
applied black
jauy123 1d1c8c4
removed not needed pass statement
jauy123 0a272ff
Update package/MDAnalysis/fetch/fetchers.py
jauy123 5d738ff
Update package/MDAnalysis/fetch/fetchers.py
jauy123 b71b637
Update package/MDAnalysis/fetch/fetchers.py
jauy123 a7ebc27
Update package/MDAnalysis/fetch/fetchers.py
jauy123 d1a0cdc
Clean up old files pass 1
jauy123 b0863d7
docstring changes!
jauy123 32715ca
added minor comments
jauy123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.