Skip to content

Add tree argument to ica_reclassify - #1360

Draft
tsalo wants to merge 6 commits into
ME-ICA:mainfrom
tsalo:reclassify-tree
Draft

Add tree argument to ica_reclassify#1360
tsalo wants to merge 6 commits into
ME-ICA:mainfrom
tsalo:reclassify-tree

Conversation

@tsalo

@tsalo tsalo commented Feb 11, 2026

Copy link
Copy Markdown
Member

Closes #1291.

The current blocker is that a new tree will involve generating some new metrics, which, if they already exist in the component tree, will raise an error.

Changes proposed in this pull request:

  • Add --tree argument to ica_reclassify.
  • Allow manacc and manrej to be empty if tree is provided.

@tsalo tsalo added the enhancement issues describing possible enhancements to the project label Feb 11, 2026
@codecov

codecov Bot commented Feb 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.15%. Comparing base (26424f8) to head (73055c2).

Files with missing lines Patch % Lines
tedana/workflows/ica_reclassify.py 28.57% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
- Coverage   90.20%   90.15%   -0.06%     
==========================================
  Files          30       30              
  Lines        4862     4865       +3     
  Branches      820      821       +1     
==========================================
  Hits         4386     4386              
- Misses        316      318       +2     
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a --tree argument to ica_reclassify, allowing users to test different decision trees on previously processed data without manually specifying components to accept or reject. This addresses issue #1291 and supports the use case where users want to experiment with different decision trees on the same dataset.

Changes:

  • Added --tree command-line argument to the ica_reclassify parser
  • Modified validation logic to allow empty manual accept/reject lists when a tree is provided
  • Updated workflow to use the specified tree instead of the previous run's tree when provided

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tedana/workflows/ica_reclassify.py Outdated
Comment thread tedana/workflows/ica_reclassify.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement issues describing possible enhancements to the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --tree input to ica_reclassify

2 participants