Add tree argument to ica_reclassify - #1360
Draft
tsalo wants to merge 6 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
- Coverage 90.20% 90.15% -0.06%
==========================================
Files 30 30
Lines 4862 4865 +3
Branches 820 821 +1
==========================================
Hits 4386 4386
- Misses 316 318 +2
- Partials 160 161 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --tree argument to ica_reclassify, allowing users to test different decision trees on previously processed data without manually specifying components to accept or reject. This addresses issue #1291 and supports the use case where users want to experiment with different decision trees on the same dataset.
Changes:
- Added
--treecommand-line argument to the ica_reclassify parser - Modified validation logic to allow empty manual accept/reject lists when a tree is provided
- Updated workflow to use the specified tree instead of the previous run's tree when provided
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1291.
The current blocker is that a new tree will involve generating some new metrics, which, if they already exist in the component tree, will raise an error.
Changes proposed in this pull request:
--treeargument toica_reclassify.