Skip to content

Use colorblind encoding in HTML report - #1475

Open
tsalo wants to merge 9 commits into
ME-ICA:mainfrom
tsalo:report-colorblind-encoding
Open

Use colorblind encoding in HTML report#1475
tsalo wants to merge 9 commits into
ME-ICA:mainfrom
tsalo:report-colorblind-encoding

Conversation

@tsalo

@tsalo tsalo commented Jul 19, 2026

Copy link
Copy Markdown
Member

Closes none.

Changes proposed in this pull request:

  • Switch red/green colors for colorblind-accessible colors. Also change the markers for rejected components to squares.
    • Maybe I should turn the accepted components to diamonds, so they're still distinct from the rejected components, but are more comparable to the squares.

@tsalo tsalo added the reports issues related to boilerplate generation or visual reports label Jul 19, 2026
@tsalo

tsalo commented Jul 19, 2026

Copy link
Copy Markdown
Member Author

Old version

image

New version

image

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.56%. Comparing base (13b78cb) to head (2f470db).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   90.43%   90.56%   +0.13%     
==========================================
  Files          31       32       +1     
  Lines        5100     5110      +10     
  Branches      937      936       -1     
==========================================
+ Hits         4612     4628      +16     
+ Misses        326      321       -5     
+ Partials      162      161       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo
tsalo marked this pull request as ready for review July 19, 2026 16:00
@tsalo
tsalo requested review from eurunuela and handwerkerd July 20, 2026 15:22
@handwerkerd

Copy link
Copy Markdown
Member

I like the approach and agreed about changing accepted to diamonds. FWIW I think the adaptive mask already uses colorblind friendly colors.

I'm currently in transit but will try to find time to review/test code soonish.

@eurunuela eurunuela left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will try to make the changes to Rica as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reports issues related to boilerplate generation or visual reports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants