Add figure showing fit failures to Decay tab of HTML report - #1478
Draft
tsalo wants to merge 13 commits into
Draft
Add figure showing fit failures to Decay tab of HTML report#1478tsalo wants to merge 13 commits into
tsalo wants to merge 13 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Guards the Parameter estimates and Curve-fit quality headings so they are not rendered with no content beneath them (e.g. a --t2smap run skips RMSE, variance, and fit-failure figures). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
It looks like they were in the wrong order, so that "Initial mask only" was on top.
tsalo
added
the
reports
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes none. If we end up liking the new figure I can add info about it to the documentation.
Changes proposed in this pull request:
Reverse order of layers in adaptive mask figure, so that "Initial mask only" is underneath other layers instead of on top.Moved to Reorder layers in adaptive mask plot #1480.Make stat_map-based figures more stylistically consistent by using a shared function.Moved to Create helper function for plotting statistical maps #1484.