fix(io): Resolves an error that could occur with seeking past the header in r2c-format files #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der in r2c-format files. When compiled using optimizations with `gcc13` and possibly `gcc12`-`14`, a bad `iostat` is returned or `ierr` seems to not hold a non-zero value, which causes the routine to exit without properly seeking the file. This causes warnings that eventually lead to the file being improperly dimensioned for time-based r2c-format files. Moving the initialization/zeroing of the `ierr` output variable before the call to `rewind` the file seems to resolve this issue in optimized code. This issue would not be encountered when compiled using `debug` symbols and was not present when using older `gcc` versions (e.g., `gcc5`-`11`). Resolves issue MESH-Model#94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiled using optimizations with
gcc13and possiblygcc12-14, a badiostatis returned orierrseems to not hold a non-zero value, which causes the routine to exit without properly seeking the file. This causes warnings that eventually lead to the file being improperly dimensioned for time-based r2c-format files. Moving the initialization/zeroing of theierroutput variable before the call torewindthe file seems to resolve this issue in optimized code. This issue would not be encountered when compiled usingdebugsymbols and was not present when using oldergccversions (e.g.,gcc5-11).Resolves issue #94.