Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitely cast to datetime64[ns] (non-ns-compat) #608

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

mathause
Copy link
Member

pandas and xarray relax the condition that datetime has to be in nano second resolution. Explicitly cast to datetime64[ns] so our tests don't fail. (Could be better to use seconds instead but for backwards compatibility we can make our live easier.) Mostly done so I can remove it from #607.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (32a5eb0) to head (b6647f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   80.40%   80.40%           
=======================================
  Files          49       49           
  Lines        3082     3082           
=======================================
  Hits         2478     2478           
  Misses        604      604           
Flag Coverage Δ
unittests 80.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit 681fa61 into MESMER-group:main Jan 31, 2025
11 checks passed
@mathause mathause deleted the cast_datetime branch January 31, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream dev issues hidden by pinned xarray
1 participant