Skip to content

Code Coverage Testing #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Code Coverage Testing #1070

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb0d0ec
Test
Nov 29, 2025
5596fdb
Added flux_wrt case
Nov 29, 2025
15a4880
Fix flux_wrt and add format = 2
Nov 29, 2025
7bd189b
Generate golden files
Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 0 additions & 103 deletions src/post_process/m_derived_variables.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ module m_derived_variables
private; public :: s_initialize_derived_variables_module, &
s_derive_specific_heat_ratio, &
s_derive_liquid_stiffness, &
s_derive_sound_speed, &
s_derive_flux_limiter, &
s_derive_vorticity_component, &
s_derive_qm, &
Expand Down Expand Up @@ -167,62 +166,6 @@ contains

end subroutine s_derive_liquid_stiffness

!> This subroutine admits as inputs the primitive variables,
!! the density, the specific heat ratio function and liquid
!! stiffness function. It then computes from those variables
!! the values of the speed of sound, which are stored in the
!! derived flow quantity storage variable, q_sf.
!! @param q_prim_vf Primitive variables
!! @param q_sf Speed of sound
subroutine s_derive_sound_speed(q_prim_vf, q_sf)

type(scalar_field), &
dimension(sys_size), &
intent(in) :: q_prim_vf

real(wp), &
dimension(-offset_x%beg:m + offset_x%end, &
-offset_y%beg:n + offset_y%end, &
-offset_z%beg:p + offset_z%end), &
intent(inout) :: q_sf

integer :: i, j, k !< Generic loop iterators

! Fluid bulk modulus for alternate sound speed
real(wp) :: blkmod1, blkmod2

! Computing speed of sound values from those of pressure, density,
! specific heat ratio function and the liquid stiffness function
do k = -offset_z%beg, p + offset_z%end
do j = -offset_y%beg, n + offset_y%end
do i = -offset_x%beg, m + offset_x%end

! Compute mixture sound speed
if (alt_soundspeed .neqv. .true.) then
q_sf(i, j, k) = (((gamma_sf(i, j, k) + 1._wp)* &
q_prim_vf(E_idx)%sf(i, j, k) + &
pi_inf_sf(i, j, k))/(gamma_sf(i, j, k)* &
rho_sf(i, j, k)))
else
blkmod1 = ((gammas(1) + 1._wp)*q_prim_vf(E_idx)%sf(i, j, k) + &
pi_infs(1))/gammas(1)
blkmod2 = ((gammas(2) + 1._wp)*q_prim_vf(E_idx)%sf(i, j, k) + &
pi_infs(2))/gammas(2)
q_sf(i, j, k) = (1._wp/(rho_sf(i, j, k)*(q_prim_vf(adv_idx%beg)%sf(i, j, k)/blkmod1 + &
(1._wp - q_prim_vf(adv_idx%beg)%sf(i, j, k))/blkmod2)))
end if

if (mixture_err .and. q_sf(i, j, k) < 0._wp) then
q_sf(i, j, k) = 1.e-16_wp
else
q_sf(i, j, k) = sqrt(q_sf(i, j, k))
end if
end do
end do
end do

end subroutine s_derive_sound_speed

!> This subroutine derives the flux_limiter at cell boundary
!! i+1/2. This is an approximation because the velocity used
!! to determine the upwind direction is the velocity at the
Expand Down Expand Up @@ -320,52 +263,6 @@ contains
end do
end subroutine s_derive_flux_limiter

!> Computes the solution to the linear system Ax=b w/ sol = x
!! @param A Input matrix
!! @param b right-hane-side
!! @param sol Solution
!! @param ndim Problem size
subroutine s_solve_linear_system(A, b, sol, ndim)

integer, intent(in) :: ndim
real(wp), dimension(ndim, ndim), intent(inout) :: A
real(wp), dimension(ndim), intent(inout) :: b
real(wp), dimension(ndim), intent(out) :: sol

!EXTERNAL DGESV

integer :: i, j, k

! Solve linear system using own linear solver (Thomson/Darter/Comet/Stampede)
! Forward elimination
do i = 1, ndim
! Pivoting
j = i - 1 + maxloc(abs(A(i:ndim, i)), 1)
sol = A(i, :)
A(i, :) = A(j, :)
A(j, :) = sol
sol(1) = b(i)
b(i) = b(j)
b(j) = sol(1)
! Elimination
b(i) = b(i)/A(i, i)
A(i, :) = A(i, :)/A(i, i)
do k = i + 1, ndim
b(k) = b(k) - A(k, i)*b(i)
A(k, :) = A(k, :) - A(k, i)*A(i, :)
end do
end do

! Backward substitution
do i = ndim, 1, -1
sol(i) = b(i)
do k = i + 1, ndim
sol(i) = sol(i) - A(i, k)*sol(k)
end do
end do

end subroutine s_solve_linear_system

!> This subroutine receives as inputs the indicator of the
!! component of the vorticity that should be outputted and
!! the primitive variables. From those inputs, it proceeds
Expand Down
13 changes: 13 additions & 0 deletions toolchain/mfc/test/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,16 @@ def mhd_cases():
for name, path, param in case_specs:
cases.append(define_case_f(name, path, mods=param))




def alter_flux_wrt():
stack.push("Flux WRT", {'flux_wrt': 'T'})

cases.append(define_case_d(stack, '', {}))
cases.append(define_case_d(stack, 'format=2', {'format': 2}))
stack.pop()

Comment on lines +976 to +982
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix trailing whitespace to resolve pipeline failures.

Lines 978 and 980 contain trailing whitespace, causing the lint step to fail.

Apply this diff to remove the trailing whitespace:

 def alter_flux_wrt():
     stack.push("Flux WRT", {'flux_wrt': 'T'})
-        
+
     cases.append(define_case_d(stack, '', {}))
-    cases.append(define_case_d(stack, 'format=2', {'format': 2}))        
+    cases.append(define_case_d(stack, 'format=2', {'format': 2}))
     stack.pop()
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def alter_flux_wrt():
stack.push("Flux WRT", {'flux_wrt': 'T'})
cases.append(define_case_d(stack, '', {}))
cases.append(define_case_d(stack, 'format=2', {'format': 2}))
stack.pop()
def alter_flux_wrt():
stack.push("Flux WRT", {'flux_wrt': 'T'})
cases.append(define_case_d(stack, '', {}))
cases.append(define_case_d(stack, 'format=2', {'format': 2}))
stack.pop()
🧰 Tools
🪛 GitHub Actions: Lint Toolchain

[error] 978-978: Pylint: Trailing whitespace (C0303) detected. Lint step 'mfc.sh lint' failed with exit code 16.

[error] 980-980: Pylint: Trailing whitespace (C0303) detected. Lint step 'mfc.sh lint' failed with exit code 16.

🤖 Prompt for AI Agents 
In toolchain/mfc/test/cases.py around lines 976 to 982, there are trailing
spaces at the ends of lines 978 and 980 causing lint failures; open the file and
remove the trailing whitespace characters on those two lines (ensure there are
no extra spaces after the closing parentheses/quotes), save the file, and run
the linter/format step to confirm the pipeline passes.

def foreach_dimension():
for dimInfo, dimParams in get_dimensions():
stack.push(f"{len(dimInfo[0])}D", dimParams)
Expand All @@ -994,6 +1004,9 @@ def foreach_dimension():
alter_body_forces(dimInfo)
alter_mixlayer_perturb(dimInfo)
alter_bc_patches(dimInfo)
alter_flux_wrt()


stack.pop()
stack.pop()

Expand Down
Loading