Fix failing pip tests #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes automatic module loading of the heavy wave.io module and is meant to fix cross module loading of unnecessary submodules. One example: `import loads` when installed via pip install "mhkit[loads]" imports `wave.resource.frequency_moment`, which also imports the unnecessary wave.io module which has a dependency on requests. This fails if the user doesn't have `requests` installed, but that module is not necessary to run `frequency_moment`.
Loads module tests call wave/contours.py which requires `statsmodels`
`requests` is small, common python library. There are some modules that pull from multiple modules (loads calls wave) which require `requests`. This always includes requests for all modules.
Loads tests call wave.contours, which need scikit-learn
Contributor
Author
|
@akeeste, this is ready for review. This installs system binaries of h5 and netcdf libraries on linux and then reinstalls and builds h5py and netcdf python libraries using these binaries. This should fix all variations of these errors in the |
Contributor
Author
|
These specific tests are passing, indicating that this fix works: 
https://github.com/MHKiT-Software/MHKiT-Python/actions/runs/18564411952 |
Merged
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready
This is a fix for failing pip tests in main.yml:
https://github.com/MHKiT-Software/MHKiT-Python/actions/runs/18511807517/job/52754343805?pr=421
https://github.com/MHKiT-Software/MHKiT-Python/actions/runs/18511807517/job/52754343883?pr=421
There are lots of errors in both of these tests related to h5 and netcdf4. One fix for this is installing the system h5 and nc binaries and having pip rebuild against these binaries