fix(xray): sync routing rules when outbound tag is renamed#5006
Open
nima1024m wants to merge 2 commits into
Open
fix(xray): sync routing rules when outbound tag is renamed#5006nima1024m wants to merge 2 commits into
nima1024m wants to merge 2 commits into
Conversation
Renaming an outbound in the Outbounds tab only updated the outbound list, leaving routing rules pointing at the old tag. Propagate tag changes to routing rules, balancer selectors, and sockopt dialerProxy references, matching the behavior already used for balancer and WARP/Nord renames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Editing an outbound only updated the outbounds array. Routing rules store outboundTag as a plain string, so renaming left rules pointing at a tag that no longer exists. Balancer renames and WARP/Nord outbound resets already updated references; the regular Outbounds edit path did not.
Files affected
Test plan
Risks