refactor: Package structure overhaul #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
svelte-maplibre-gl | 34e315b | Commit Preview URL | Jun 13 2025, 12:22 AM |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the package structure by splitting the monolithic package into a core package and several extension packages, and updates the CI/CD workflows to support changesets and automated releases.
- Added new extension packages (deckgl, contour) with their associated configuration and source files.
- Updated SvelteKit, TypeScript, and workflow configurations to streamline building, packaging, and releasing.
Reviewed Changes
Copilot reviewed 360 out of 360 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/deckgl/package.json | Added deckgl extension package metadata and dependency configuration. |
| extensions/deckgl/.svelte-kit/* | Introduced SvelteKit packaging files (types, tsconfig, package) for deckgl. |
| extensions/deckgl/.svelte-kit/package/DeckGLOverlay.svelte | Updated import for getMapContext to reflect the new package structure. |
| extensions/contour/* | Added contour extension package files including its Svelte source, configuration, and packaging settings. |
| .prettierignore | Extended ignore patterns to include build output and SvelteKit directories. |
| .github/workflows/release.yml | Revised release workflow for automated publishing and enhanced permissions. |
| .github/workflows/preview.yml | Modified preview workflow to build and publish package previews. |
| .changeset/* | Added changesets configuration and documentation to manage versioning and releases. |
Comments suppressed due to low confidence (2)
extensions/deckgl/.svelte-kit/package/DeckGLOverlay.svelte:5
- Confirm that the updated import path for getMapContext aligns with the restructured package and that the exported API remains consistent with its previous usage.
import { getMapContext } from 'svelte-maplibre-gl';
extensions/deckgl/package.json:50
- Verify that the use of the version specifier 'catalog:' for deck.gl dependencies is intentional and supported by your dependency management setup.
"@deck.gl/core": "catalog:"
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - name: Create Release Pull Request or Publish to npm | ||
| id: changesets | ||
| uses: changesets/action@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
ciscorn
force-pushed
the
refactor-package-overhaul
branch
2 times, most recently
from
834b804 to
f4dada9
Compare
svelte-maplibre-gl
@svelte-maplibre-gl/contour
@svelte-maplibre-gl/deckgl
@svelte-maplibre-gl/pmtiles
@svelte-maplibre-gl/terradraw
commit: |
ciscorn
force-pushed
the
refactor-package-overhaul
branch
2 times, most recently
from
146690f to
6b9caa7
Compare
ciscorn
force-pushed
the
refactor-package-overhaul
branch
from
6b9caa7 to
7d1c2de
Compare
ciscorn
added a commit
that referenced
this pull request
Jun 13, 2025
ciscorn
added a commit
that referenced
this pull request
Jun 13, 2025
ciscorn
added a commit
that referenced
this pull request
Jun 13, 2025
ciscorn
added a commit
that referenced
this pull request
Jun 13, 2025
ciscorn
added a commit
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svelte-maplibre-glpackage and extensions (@svelte-maplibre-gl/pmtiles,@svelte-maplibre-gl/contour,@svelte-maplibre-gl/deckgl,@svelte-maplibre-gl/terradraw)