Skip to content

Conversation

@ciscorn
Copy link
Member

@ciscorn ciscorn commented Jul 9, 2025

Resolves #123

Copilot AI review requested due to automatic review settings July 9, 2025 12:10
@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025

🦋 Changeset detected

Latest commit: ccfc05e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@svelte-maplibre-gl/docs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ciscorn ciscorn self-assigned this Jul 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A patch to prevent an infinite reactive loop in the GeolocateControl Svelte component, bump related dependencies, and document the fix.

  • Wrap control removal and addition in untrack to stop $effect from retriggering endlessly.
  • Bump maplibre-gl, svelte, and bits-ui versions.
  • Add a changeset entry for the patch.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/lib/controls/GeolocateControl.svelte Use untrack around control operations to fix looping
pnpm-workspace.yaml Update maplibre-gl and svelte version constraints
package.json Bump bits-ui dependency version
.changeset/free-trams-peel.md Document the patch (contains a typo)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 9, 2025

Open in StackBlitz

svelte-maplibre-gl

npm i https://pkg.pr.new/MIERUNE/svelte-maplibre-gl@125

@svelte-maplibre-gl/contour

npm i https://pkg.pr.new/MIERUNE/svelte-maplibre-gl/@svelte-maplibre-gl/contour@125

@svelte-maplibre-gl/deckgl

npm i https://pkg.pr.new/MIERUNE/svelte-maplibre-gl/@svelte-maplibre-gl/deckgl@125

@svelte-maplibre-gl/pmtiles

npm i https://pkg.pr.new/MIERUNE/svelte-maplibre-gl/@svelte-maplibre-gl/pmtiles@125

@svelte-maplibre-gl/terradraw

npm i https://pkg.pr.new/MIERUNE/svelte-maplibre-gl/@svelte-maplibre-gl/terradraw@125

commit: ccfc05e

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 9, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
svelte-maplibre-gl ccfc05e Commit Preview URL Jul 09 2025, 12:54 PM

@ciscorn ciscorn merged commit 4e38f39 into main Jul 9, 2025
7 checks passed
@ciscorn ciscorn deleted the fix-geoloc branch July 9, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite effect loop using the GeolocateControl component after 1.0.0

2 participants