-
Notifications
You must be signed in to change notification settings - Fork 11
fix: GeolocationControl causes inifinite $effect loop with latest Svelte #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ccfc05e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A patch to prevent an infinite reactive loop in the GeolocateControl Svelte component, bump related dependencies, and document the fix.
- Wrap control removal and addition in
untrackto stop$effectfrom retriggering endlessly. - Bump
maplibre-gl,svelte, andbits-uiversions. - Add a changeset entry for the patch.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/controls/GeolocateControl.svelte | Use untrack around control operations to fix looping |
| pnpm-workspace.yaml | Update maplibre-gl and svelte version constraints |
| package.json | Bump bits-ui dependency version |
| .changeset/free-trams-peel.md | Document the patch (contains a typo) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
svelte-maplibre-gl
@svelte-maplibre-gl/contour
@svelte-maplibre-gl/deckgl
@svelte-maplibre-gl/pmtiles
@svelte-maplibre-gl/terradraw
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
svelte-maplibre-gl | ccfc05e | Commit Preview URL | Jul 09 2025, 12:54 PM |
Resolves #123