Conversation
|
Thank you very much @th3r3d . Can you have a quick look and fix it? Before running, please run the Also make sure to re-generate the readme: Lastly, would you be open to also share the script you used to generate this galaxy? If all works well with above scripts, tests should run fine. |
|
I did all script checks, but Im not able to do update README. You were right on line 3 was missing comma. I will try later on linux machine, it maybe some mac thing. |
|
I did came through all checks (fix few more typos and unsupported values) and get OK message with, but Im not able to run update README script. |
|
All right finally - all done now. Thanks for patience |
|
@th3r3d Can you review the PR to make the test pass? Thanks a lot. |
th3r3d
left a comment
There was a problem hiding this comment.
Fixed README for Engage
|
|
|
I see some files from your Python env in this pull-request ;-) Can you remove all those files? or do another PR? |
|
Will do new PR |
|
Done |
|
Thank you. Can you remove the files which are not related https://github.com/MISP/misp-galaxy/pull/1013/files ? or do a clean pull-request. I really would like to merge it. |
|
Any news for the updated PR? Thanks a lot. |
|
I'll do new PR on weekend together with ADS object update. |

I tried my best to create MISP Galaxy for MITRE Engage. More can be seen at https://engage.mitre.org