Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames the package from cuPDLPx to CuPDLPx to comply with Julia's package naming guidelines, which require proper capitalization for acronyms.
Changes:
- Renamed main package and module from
cuPDLPxtoCuPDLPx - Renamed submodule from
LibcuPDLPxtoLibCuPDLPx - Updated all references throughout documentation, tests, and generator configuration
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Project.toml | Updated package name from cuPDLPx to CuPDLPx |
| Manifest.toml | Updated dependency entry with new package name and relocated in alphabetical order |
| src/cuPDLPx.jl | Removed old main module file |
| src/CuPDLPx.jl | Created new main module file with updated naming |
| src/LibCuPDLPx.jl | Updated module declaration from LibcuPDLPx to LibCuPDLPx |
| src/MOI_wrapper.jl | Updated all references to use new CuPDLPx and LibCuPDLPx names |
| test/runtests.jl | Updated imports and testset names to use new naming |
| test/MOI_wrapper.jl | Updated imports and optimizer references to use new naming |
| gen/generate.toml | Updated output file path and module name configuration |
| gen/generate.jl | Updated output file path references and success message |
| README.md | Updated all package references and usage examples (external repository URL correctly unchanged) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames cuPDLPx to CuPDLPx to obey Julia's Package naming rule.
Related issue: JuliaRegistries/General#146726