IN 1200 - Remove 2019 data cutoff #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: It was determined that filtering data older than 2019-01-01 is not needed and should no longer be performed by the data loader. How this addresses that need: * Removes SQL filtering for 2019-01-01 * Filtering for more recent data will be done client-side in Quickbase Side effects of this change: * Increased row counts for all tables touched Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1200
ghukill
commented
Mar 6, 2025
Comment on lines
+46
to
+57
| row_number() over ( | ||
| partition by MIT_ID | ||
| order by APPT_BEGIN_DATE desc, APPT_END_DATE desc | ||
| ) as termination_txn_row_num | ||
| from HR_APPT_ACTION_DETAIL ad | ||
| left join HR_PERSONNEL_ACTION_TYPE at on at.HR_PERSONNEL_ACTION_TYPE_KEY = ad.HR_PERSONNEL_ACTION_TYPE_KEY | ||
| where at.HR_PERSONNEL_ACTION in ('Retirement','Termination') | ||
| ), | ||
| last_appt_termination_txn as ( | ||
| select * from appt_termination_txns | ||
| where termination_txn_row_num = 1 | ||
| ), |
There was a problem hiding this comment.
The addition of the row_number() sorts the termination reasons, and the new last_appt_termination_txn CTE allows for getting only the most recent one, i.e. the "last" termination reason.
There was a problem hiding this comment.
I follow! Hmm, is there every a scenario like the following?:
[{
"APPT_BEGIN_DATE": "2024-01-01",
"APPT_END_DATE": "2025-01-01",
"termination_txn_row_num": 1
},
{
"APPT_BEGIN_DATE": "2023-12-31"
"APPT_END_DATE": "2025-02-01"
"termination_txn_row_num": 2
}]
jonavellecuerdo
approved these changes
Mar 6, 2025
| @@ -11,6 +11,7 @@ CHANGELOG | |||
| - 2024-05-13 Query created and added | |||
| - 2024-06-03 Limit rows to appointments that end on or before 2019-01-01 | |||
| - 2024-06-05 Do not filter on benefits types | |||
| - 2025-02-05 Remove 2019-01-01 date cutoff entirely | |||
There was a problem hiding this comment.
Hmm, curious why you included this in the changelog if no changes -- beyond this updated comment -- are present in this script?
There was a problem hiding this comment.
Maybe it got lost in the diff, but this was removed in this file:
where a.APPT_END_DATE >= TO_DATE('2019-01-01', 'YYYY-MM-DD')
Comment on lines
+46
to
+57
| row_number() over ( | ||
| partition by MIT_ID | ||
| order by APPT_BEGIN_DATE desc, APPT_END_DATE desc | ||
| ) as termination_txn_row_num | ||
| from HR_APPT_ACTION_DETAIL ad | ||
| left join HR_PERSONNEL_ACTION_TYPE at on at.HR_PERSONNEL_ACTION_TYPE_KEY = ad.HR_PERSONNEL_ACTION_TYPE_KEY | ||
| where at.HR_PERSONNEL_ACTION in ('Retirement','Termination') | ||
| ), | ||
| last_appt_termination_txn as ( | ||
| select * from appt_termination_txns | ||
| where termination_txn_row_num = 1 | ||
| ), |
There was a problem hiding this comment.
I follow! Hmm, is there every a scenario like the following?:
[{
"APPT_BEGIN_DATE": "2024-01-01",
"APPT_END_DATE": "2025-01-01",
"termination_txn_row_num": 1
},
{
"APPT_BEGIN_DATE": "2023-12-31"
"APPT_END_DATE": "2025-02-01"
"termination_txn_row_num": 2
}]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
It was determined that filtering data older than
2019-01-01is not needed and should no longer be performed by the data loader.How this addresses that need:
2019-01-01How can a reviewer manually see the effects of these changes?
Not possible at this time.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)