be careful about signed zero for complex real isequal (JuliaLang#48997)

MLH-Fellowship · Mar 25, 2023 · 4853a52 · 4853a52
1 parent 88a1fc7
commit 4853a52
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/base/complex.jl b/base/complex.jl
@@ -245,6 +245,8 @@ bswap(z::Complex) = Complex(bswap(real(z)), bswap(imag(z)))
 ==(x::Real, z::Complex) = isreal(z) && real(z) == x
 
 isequal(z::Complex, w::Complex) = isequal(real(z),real(w)) & isequal(imag(z),imag(w))
+isequal(z::Complex, w::Real) = isequal(real(z),w) & isequal(imag(z),zero(w))
+isequal(z::Real, w::Complex) = isequal(z,real(w)) & isequal(zero(z),imag(w))
 
 in(x::Complex, r::AbstractRange{<:Real}) = isreal(x) && real(x) in r
 

diff --git a/test/complex.jl b/test/complex.jl
@@ -44,7 +44,12 @@ end
     @testset for T in (Float16, Float32, Float64, BigFloat)
         t = true
         f = false
-
+        @testset "equality" begin
+            @test isequal(T(0.0)*im, T(0.0))
+            @test !isequal(T(0.0)*im, T(-0.0))
+            @test isequal(Complex(T(-0.0), T(0.0)), T(-0.0))
+            @test !isequal(T(-0.0)*im, T(-0.0))
+        end
         @testset "add and subtract" begin
             @test isequal(T(+0.0) + im, Complex(T(+0.0), T(+1.0)))
             @test isequal(T(-0.0) + im, Complex(T(-0.0), T(+1.0)))