[pull] master from JuliaLang:master #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This commit adds libTracyClient as an optional build dependency,
to be used for profiling the base Julia runtime. Support can be
enabled by adding `WITH_TRACY := 1` to Make.user
Here's an example instrumentation:
```c
TracyCZoneN(ctx, "jl_subtype_env", true);
int r = jl_subtype_env(x, y, NULL, 0);
TracyCZoneEnd(ctx);
return r;
```
This only adds Tracy itself. In a follow-up commit, I'll update the
JL_TIMING macros to hook into Tracy when available.
This version includes the full set of feature flags that we use to customize Tracy to, e.g., accept on-demand connections instead of queuing profiling data until receiving a connection.
Loading libjulia-internal and libjulia-codegen can trigger constructors in their dependencies, including some which may spawn threads (e.g. Tracy). It is important that these not be configured to receive any signals that libjulia-internal is expecting to `sigwait()` on, esp. when their default action is to terminate the process. Technically, the masked signal set should probably be synchronized with the `sigwait_sigs` set in `signals-unix.c`, but for now this simply masks all signals.
This is the right strategy according to #31530, so that the patching process doesn't hit any races between multiple builds running from the same SRCCACHE.
Add Tracy as optional dependency for profiling
cross-reference names from varinfo docstring
Let Base handle concatenation of arrays and numbers
Add GC.in_finalizer query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )