[pull] master from JuliaLang:master #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This commit drops the usage of `intvalued==2` We now records the correct `occurs_inv` (== 2), thus re-intersection would always happen if needed.
1. code clean for `intvalued` 2. fix stackoverflow caused by re-intersection of concrete var 3. NFC clean for #49049
This commit reworks our handling of `(src::CodeInfo).slottypes` and
`(ir::IRCode).argtypes`. Currently `ir.argtypes` contains types for call
arguments and local slots even after the SSA conversion (`slot2reg`),
which can be quite confusing. Similarly, `src.slot[names|flags|types]`
contains information about local slots regardless of whether `src` is
optimized or not, even though local slots never appear within `src`.
With this commit, we resize `ir.argtypes` so that it only contains
information about call arguments after `slot2reg`, as well as resize
`src.slot[names|flags|types]` after optimization.
This commit removes unnecessary information upon appropriate timings and
allows us to use `Core.OpaqueClosure(ir::IRCode)` constructor for such
`ir` that is retrieved by `Base.code_ircode`:
```julia
let ir = first(only(Base.code_ircode(sin, (Int,))))
@test OpaqueClosure(ir)(42) == sin(42)
ir = first(only(Base.code_ircode(sin, (Float64,))))
@test OpaqueClosure(ir)(42.) == sin(42.)
end
```
Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )