Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DELETE Endpoint for Experience Entries #68

Merged
merged 3 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,17 @@ def experience():
return jsonify({"message": "New experience created", "id": len(data["experience"]) - 1}), 201


@app.route("/resume/experience/<int:index>", methods=["DELETE"])
def delete_experience(index):
"""
Delete experience entry by index
"""
if 0 <= index < len(data["experience"]):
data["experience"].pop(index)
return jsonify({"message": "Experience entry successfully deleted"}), 200
return jsonify({"error": "Experience entry not found"}), 404


@app.route("/resume/education", methods=["GET", "POST"])
def education():
"""
Expand Down
24 changes: 24 additions & 0 deletions test_pytest.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,30 @@ def test_experience(client):
response = client.get("/resume/experience")
assert response.json[item_id] == example_experience

def test_delete_experience(client):
"""Test the experience deletion endpoint."""
get_response = client.get("/resume/experience")
assert get_response.status_code == 200
initial_experience_count = len(get_response.json)

last_index = initial_experience_count - 1
response = client.delete(f"/resume/experience/{last_index}")
assert response.status_code == 200
assert response.json["message"] == "Experience entry successfully deleted"

get_response_after_delete = client.get("/resume/experience")
assert get_response_after_delete.status_code == 200
assert len(get_response_after_delete.json) == initial_experience_count - 1

response = client.delete(f"/resume/experience/{last_index}")
assert response.status_code == 404
assert response.json["error"] == "Experience entry not found"

invalid_index = initial_experience_count + 1
response = client.delete(f"/resume/experience/{invalid_index}")
assert response.status_code == 404
assert response.json["error"] == "Experience entry not found"


def test_education(client):
"""Add a new education and check if it's returned in the list."""
Expand Down
Loading